Port sqm-partner-info-modal early partner creation to 1.x - #513
Closed
Coleton (Locrian24) wants to merge 4 commits into
Closed
Port sqm-partner-info-modal early partner creation to 1.x#513Coleton (Locrian24) wants to merge 4 commits into
Coleton (Locrian24) wants to merge 4 commits into
Conversation
Hand-port the partner-info modal and connectionStatus tax/cash wiring from cash-reward-redemption, adapted for 1.x Shoelace theming without 2.x BrandingConfig or stateController preview infrastructure.
…code-verification
…ch/program-tools into port/partner-info-modal
AndiLuo
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqm-partner-info-modaland the linked widget-verification → tax/cashconnectionStatusflow fromcash-reward-redemption/ PR Cash reward redemption #490 onto the1.xmaintenance line.type="primary", no 2.x--sqm-primary-button-*/ BrandingConfig) and omitsstateController/parseStatescontent-editor preview infra.connectPartner/ US & no-indirect-tax skip routing,STARTED→completeImpactConnectionbranching in user-info and indirect-tax forms, phone validation helpers, and the two PR Cash reward redemption #490useTaxAndCashdefect fixes (refetch fromGET_USER+ success/error handling before routing).Resolved decisions (not open questions)
publish-package.ymlmint-components gap does not block this PR.1.xnever listedmint-componentsin that workflow; 1.x publishes have used the manual bump/build/npm publishpath withpublishConfig.tag: "v1-mint". Wiring mint intopublish-package.ymlis not a small safe fix here: 1.x mint has noprepack, andstencil build --docshas a known tax-and-cash docs stack-overflow. Defer a dedicated CI follow-up; shipping this feature still works via the existing 1.x publish path.allowBankingCollectionprops left intentionally. T&C checkbox lives on the partner modal (same intent as PR Cash reward redemption #490’s “Move T&Cs checkbox…” / flagged-for-deletion on step 1). Removing the@Props fromsqm-user-info-form/step1_*onsqm-tax-and-cashwould churn content-editor configs, readmes, andcomponents.d.tswithout runtime benefit — not safe/simple in this port.connectionStatus,startImpactConnection,completeImpactConnection) is version-agnostic; COMPLETED cohort short-circuits billing/phone revalidation ingetCurrentStep; STARTED auto-complete + skip paths use the PR branching (not master’s create-onlyconnectPartner);overrideNextStepuses correct parentheses (override || (skip ? "/3" : "/2")).Test plan
cd packages/mint-components && npx tsc --noEmit(already clean on this branch)startImpactConnection→NOT_STARTED→STARTED, then advance past verification/3(or override) viacompleteImpactConnectionwhen status isSTARTEDSTARTED+ full billing:useTaxAndCashauto-completes then routes off refreshed user data/1v1-mintpublish path (notpublish-package.yml)