Coding Standards: Use strict comparison in bundled themes' PHP files.

This addresses all the remaining WPCS warnings in bundled themes.

Includes using the correct type when checking the number of comments, as `get_comments_number()` returns a numeric string, not an integer.

Follow-up to [41285], [44562], [47941].

Props aristath, poena, afercia, SergeyBiryukov.
See #56791.

git-svn-id: https://develop.svn.wordpress.org/trunk@55420 602fd350-edb4-49c9-b593-d223f7449a82

Author: SergeyBiryukov

src/wp-content/themes/twentyeleven/comments.php

@@ -31,7 +31,7 @@
 	<?php if ( have_comments() ) : ?>
 		<h2 id="comments-title">
 			<?php
-			if ( 1 === get_comments_number() ) {
+			if ( '1' === get_comments_number() ) {
 				printf(
 					/* translators: %s: The post title. */
 					__( 'One thought on &ldquo;%1$s&rdquo;', 'twentyeleven' ),

src/wp-content/themes/twentyeleven/functions.php

@@ -322,7 +322,7 @@ function twentyeleven_header_style() {
 		$text_color = get_header_textcolor();
 
 		// If no custom options for text are set, let's bail.
-		if ( HEADER_TEXTCOLOR == $text_color ) {
+		if ( HEADER_TEXTCOLOR === $text_color ) {
 			return;
 		}
 
@@ -386,7 +386,7 @@ function twentyeleven_admin_header_style() {
 	}
 		<?php
 		// If the user has set a custom color for the text, use that.
-		if ( get_header_textcolor() != HEADER_TEXTCOLOR ) :
+		if ( get_header_textcolor() !== HEADER_TEXTCOLOR ) :
 			?>
 	#site-title a,
 	#site-description {
@@ -724,7 +724,7 @@ function twentyeleven_comment( $comment, $args, $depth ) {
 					<?php
 					$avatar_size = 68;
 
-					if ( '0' != $comment->comment_parent ) {
+					if ( '0' !== $comment->comment_parent ) {
 						$avatar_size = 39;
 					}
 
@@ -756,7 +756,7 @@ function twentyeleven_comment( $comment, $args, $depth ) {
 					}
 					?>
 
-					<?php if ( '0' == $comment->comment_approved ) : ?>
+					<?php if ( '0' === $comment->comment_approved ) : ?>
 					<em class="comment-awaiting-moderation"><?php echo $moderation_note; ?></em>
 					<br />
 					<?php endif; ?>

src/wp-content/themes/twentyeleven/image.php

@@ -70,7 +70,7 @@
 					)
 				);
 				foreach ( $attachments as $k => $attachment ) {
-					if ( $attachment->ID == $post->ID ) {
+					if ( $attachment->ID === $post->ID ) {
 						break;
 					}
 				}

src/wp-content/themes/twentyeleven/inc/theme-options.php

@@ -446,7 +446,7 @@ function twentyeleven_print_link_color_style() {
 	$default_options = twentyeleven_get_default_theme_options();
 
 	// Don't do anything if the current link color is the default.
-	if ( $default_options['link_color'] == $link_color ) {
+	if ( $default_options['link_color'] === $link_color ) {
 		return;
 	}
 	?>

src/wp-content/themes/twentyeleven/showcase.php

@@ -154,7 +154,7 @@
 							while ( $featured->have_posts() ) :
 								$featured->the_post();
 								$counter_slider++;
-								if ( 1 == $counter_slider ) {
+								if ( 1 === $counter_slider ) {
 									$class = ' class="active"';
 								} else {
 									$class = '';

src/wp-content/themes/twentyfourteen/functions.php

@@ -471,7 +471,7 @@ function twentyfourteen_the_attached_image() {
 		// If there is more than 1 attachment in a gallery...
 		if ( count( $attachment_ids ) > 1 ) {
 			foreach ( $attachment_ids as $idx => $attachment_id ) {
-				if ( $attachment_id == $post->ID ) {
+				if ( $attachment_id === $post->ID ) {
 					$next_id = $attachment_ids[ ( $idx + 1 ) % count( $attachment_ids ) ];
 					break;
 				}

src/wp-content/themes/twentyfourteen/inc/custom-header.php

@@ -82,7 +82,7 @@ function twentyfourteen_header_style() {
 		}
 			<?php
 			// If the user has set a custom color for the text, use that.
-		elseif ( get_theme_support( 'custom-header', 'default-text-color' ) != $text_color ) :
+		elseif ( get_theme_support( 'custom-header', 'default-text-color' ) !== $text_color ) :
 			?>
 		.site-title a {
 			color: #<?php echo esc_attr( $text_color ); ?>;

src/wp-content/themes/twentyfourteen/inc/featured-content.php

@@ -262,7 +262,7 @@ public static function pre_get_posts( $query ) {
 	public static function delete_post_tag( $tag_id ) {
 		$settings = self::get_setting();
 
-		if ( empty( $settings['tag-id'] ) || $tag_id != $settings['tag-id'] ) {
+		if ( empty( $settings['tag-id'] ) || $tag_id !== $settings['tag-id'] ) {
 			return;
 		}
 

src/wp-content/themes/twentynineteen/classes/class-twentynineteen-walker-comment.php

@@ -36,7 +36,7 @@ protected function html5_comment( $comment, $depth, $args ) {
 						$comment_author_url = get_comment_author_url( $comment );
 						$comment_author     = get_comment_author( $comment );
 						$avatar             = get_avatar( $comment, $args['avatar_size'] );
-						if ( 0 != $args['avatar_size'] ) {
+						if ( 0 !== (int) $args['avatar_size'] ) {
 							if ( empty( $comment_author_url ) ) {
 								echo $avatar;
 							} else {
@@ -98,7 +98,7 @@ protected function html5_comment( $comment, $depth, $args ) {
 					}
 					?>
 
-					<?php if ( '0' == $comment->comment_approved ) : ?>
+					<?php if ( '0' === $comment->comment_approved ) : ?>
 					<p class="comment-awaiting-moderation"><?php echo $moderation_note; ?></p>
 					<?php endif; ?>
 

src/wp-content/themes/twentynineteen/comments.php

@@ -35,7 +35,7 @@
 				_e( 'Leave a comment', 'twentynineteen' );
 			}
 		} else {
-			if ( '1' == $discussion->responses ) {
+			if ( '1' === (string) $discussion->responses ) {
 				/* translators: %s: Post title. */
 				printf( _x( 'One reply on “%s”', 'comments title', 'twentynineteen' ), get_the_title() );
 			} else {