Code Modernization: Use null coalescing operator instead of isset() with if/else statements.

Developed in WordPress#10711

Follow-up to [61457], [61456], [61455], [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

See #58874, #63430.


git-svn-id: https://develop.svn.wordpress.org/trunk@61463 602fd350-edb4-49c9-b593-d223f7449a82

Author: westonruter

src/wp-admin/includes/class-wp-importer.php

@@ -311,11 +311,7 @@ function get_cli_args( $param, $required = false ) {
 			$parts = explode( '=', $match[1] );
 			$key   = preg_replace( '/[^a-z0-9]+/', '', $parts[0] );
 
-			if ( isset( $parts[1] ) ) {
-				$out[ $key ] = $parts[1];
-			} else {
-				$out[ $key ] = true;
-			}
+			$out[ $key ] = $parts[1] ?? true;
 
 			$last_arg = $key;
 		} elseif ( (bool) preg_match( '/^-([a-zA-Z0-9]+)/', $args[ $i ], $match ) ) {

src/wp-admin/includes/post.php

@@ -122,11 +122,7 @@ function _wp_translate_postdata( $update = false, $post_data = null ) {
 		$post_data['post_status'] = 'pending';
 	}
 
-	if ( isset( $post_data['ID'] ) ) {
-		$post_id = $post_data['ID'];
-	} else {
-		$post_id = false;
-	}
+	$post_id         = $post_data['ID'] ?? false;
 	$previous_status = $post_id ? get_post_field( 'post_status', $post_id ) : false;
 
 	if ( isset( $post_data['post_status'] ) && 'private' === $post_data['post_status'] && ! current_user_can( $ptype->cap->publish_posts ) ) {

src/wp-admin/includes/template.php

@@ -2296,12 +2296,7 @@ function _post_states( $post, $display = true ) {
  */
 function get_post_states( $post ) {
 	$post_states = array();
-
-	if ( isset( $_REQUEST['post_status'] ) ) {
-		$post_status = $_REQUEST['post_status'];
-	} else {
-		$post_status = '';
-	}
+	$post_status = $_REQUEST['post_status'] ?? '';
 
 	if ( ! empty( $post->post_password ) ) {
 		$post_states['protected'] = _x( 'Password protected', 'post status' );

src/wp-admin/includes/theme.php

@@ -400,11 +400,7 @@ function get_theme_feature_list( $api = true ) {
 		$wporg_features[ $feature_category ] = array();
 
 		foreach ( $feature_items as $feature ) {
-			if ( isset( $features[ $feature_category ][ $feature ] ) ) {
-				$wporg_features[ $feature_category ][ $feature ] = $features[ $feature_category ][ $feature ];
-			} else {
-				$wporg_features[ $feature_category ][ $feature ] = $feature;
-			}
+			$wporg_features[ $feature_category ][ $feature ] = $features[ $feature_category ][ $feature ] ?? $feature;
 		}
 	}
 

src/wp-admin/upgrade.php

@@ -23,11 +23,7 @@
 
 delete_site_transient( 'update_core' );
 
-if ( isset( $_GET['step'] ) ) {
-	$step = $_GET['step'];
-} else {
-	$step = 0;
-}
+$step = $_GET['step'] ?? 0;
 
 // Do it. No output.
 if ( 'upgrade_db' === $step ) {

src/wp-includes/class-wp-date-query.php

@@ -208,11 +208,7 @@ public function sanitize_query( $queries, $parent_query = null ) {
 				continue;
 			}
 
-			if ( isset( $parent_query[ $dkey ] ) ) {
-				$queries[ $dkey ] = $parent_query[ $dkey ];
-			} else {
-				$queries[ $dkey ] = $dvalue;
-			}
+			$queries[ $dkey ] = $parent_query[ $dkey ] ?? $dvalue;
 		}
 
 		// Validate the dates passed in the query.

src/wp-includes/class-wp-http-streams.php

@@ -77,11 +77,7 @@ public function request( $url, $args = array() ) {
 		}
 
 		if ( isset( $parsed_args['headers']['Host'] ) || isset( $parsed_args['headers']['host'] ) ) {
-			if ( isset( $parsed_args['headers']['Host'] ) ) {
-				$parsed_url['host'] = $parsed_args['headers']['Host'];
-			} else {
-				$parsed_url['host'] = $parsed_args['headers']['host'];
-			}
+			$parsed_url['host'] = $parsed_args['headers']['Host'] ?? $parsed_args['headers']['host'];
 			unset( $parsed_args['headers']['Host'], $parsed_args['headers']['host'] );
 		}
 

src/wp-includes/class-wp-post-type.php

@@ -655,11 +655,7 @@ public function set_props( $args ) {
 				$args['rewrite']['feeds'] = (bool) $args['has_archive'];
 			}
 			if ( ! isset( $args['rewrite']['ep_mask'] ) ) {
-				if ( isset( $args['permalink_epmask'] ) ) {
-					$args['rewrite']['ep_mask'] = $args['permalink_epmask'];
-				} else {
-					$args['rewrite']['ep_mask'] = EP_PERMALINK;
-				}
+				$args['rewrite']['ep_mask'] = $args['permalink_epmask'] ?? EP_PERMALINK;
 			}
 		}
 

src/wp-includes/class-wp-styles.php

@@ -178,11 +178,7 @@ public function do_item( $handle, $group = false ) {
 			}
 		}
 
-		if ( isset( $obj->args ) ) {
-			$media = $obj->args;
-		} else {
-			$media = 'all';
-		}
+		$media = $obj->args ?? 'all';
 
 		// A single item may alias a set of items, by having dependencies, but no source.
 		if ( ! $src ) {

src/wp-includes/class-wp-xmlrpc-server.php

@@ -3673,11 +3673,7 @@ public function wp_getComments( $args ) {
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getComments', $args, $this );
 
-		if ( isset( $struct['status'] ) ) {
-			$status = $struct['status'];
-		} else {
-			$status = '';
-		}
+		$status = $struct['status'] ?? '';
 
 		if ( ! current_user_can( 'moderate_comments' ) && 'approve' !== $status ) {
 			return new IXR_Error( 401, __( 'Invalid comment status.' ) );