fix(data-grid): prevent column header sorting popover from closing when cell is focused#1114
Merged
Merged
Conversation
…focused Expand getIsInPopover to include Radix dropdown and popover content. When a cell was focused and the user clicked a column header to sort, the grid's focusout handler was stealing focus back to the cell because the dropdown content wasn't recognized as a valid popover. This caused the sorting popover to close immediately. Fixes #1108 Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where the column header sorting dropdown would close immediately when a table cell was focused. The issue occurred because the data grid's focus management logic didn't recognize Radix UI dropdown and popover content as valid popup contexts, causing focus to be incorrectly reclaimed from the sorting dropdown.
Changes:
- Expanded
getIsInPopoverutility function to recognize Radix UI dropdown-menu-content and popover-content elements - Refactored the function logic to use early return pattern for better readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand getIsInPopover to include Radix dropdown and popover content. When a cell was focused and the user clicked a column header to sort, the grid's focusout handler was stealing focus back to the cell because the dropdown content wasn't recognized as a valid popover. This caused the sorting popover to close immediately.
Fixes #1108