Skip to content

fix(data-grid): prevent column header sorting popover from closing when cell is focused #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadmann7 merged 2 commits into from
Feb 24, 2026
Merged

fix(data-grid): prevent column header sorting popover from closing when cell is focused #1114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc43a1
fix: prevent column header sorting popover from closing when cell is …
sadmann7 Feb 24, 2026
659ced9
chore: sync
sadmann7 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/lib/data-grid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,13 @@ export function scrollCellIntoView<TData>(params: {
}

export function getIsInPopover(element: unknown): boolean {
if (!(element instanceof Element)) return false;

return (
element instanceof Element &&
(element.closest("[data-grid-cell-editor]") ||
element.closest("[data-grid-popover]")) !== null
element.closest("[data-grid-cell-editor]") !== null ||
element.closest("[data-grid-popover]") !== null ||
element.closest("[data-slot='dropdown-menu-content']") !== null ||
element.closest("[data-slot='popover-content']") !== null
);
}
Comment thread
sadmann7 marked this conversation as resolved.

Expand Down