Remember selected sessions and add rename#55
Open
cualvarez wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.updateAPI.Why
The webview could fall back to, or remain visually stuck on, the initial "New Session" after switching sessions. The selected session was persisted and became visible after the webview remounted, but the live UI could be reset by the SDK init effect because it indirectly tracked
currentSessionIdthroughsetCurrentSessionId().This PR makes session selection durable and keeps the live webview aligned with the user's selected session.
Changes
untrack()so user-driven session changes are not overwritten.session-changedand test coverage.Validation
corepack pnpm run build:webviewcorepack pnpm run build:extensioncorepack pnpm exec vitest rungit diff --check