chore(deps): update dependency @react-native-community/slider to v4.5.7#21
chore(deps): update dependency @react-native-community/slider to v4.5.7#21renovate[bot] wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "integrity": "sha512-WdjvGtqJfqcCiLwtbzie53Z/H6w6dIfRHhlW832D89ySAdE5DxLAsqRhDOG0eacuAxxEB+T9sGCkVMD0fa3aBg==", | ||
| "dev": true | ||
| }, | ||
| "node_modules/@react-native/assets-registry": { |
There was a problem hiding this comment.
The pull request seems to be updating the version of "@react-native-community/slider" from 4.4.2 to 4.4.3, which looks good. However, it would be helpful if there was a description of why this update is needed. It's also important to ensure that all tests pass after the update. Overall, the code changes seem fine. 👍
| "@react-native-community/slider": "4.4.3", | ||
| "@storybook/addon-actions": "^6.5.16", | ||
| "@storybook/addon-controls": "^6.5.16", | ||
| "@storybook/addon-ondevice-actions": "^6.5.6", |
There was a problem hiding this comment.
The code changes look good to me! Updating "@react-native-community/slider" version to "4.4.3" seems like a reasonable update to make. I don't have any further suggestions to improve the changes.👍
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
f05b429 to
866b9ad
Compare
| "@react-native-community/slider": "4.4.3", | ||
| "@storybook/addon-actions": "^6.5.16", | ||
| "@storybook/addon-controls": "^6.5.16", | ||
| "@storybook/addon-ondevice-actions": "^6.5.6", |
There was a problem hiding this comment.
The code change in the pull request seems fine to me. Updating "@react-native-community/slider" from version "4.4.2" to "4.4.3" should not cause any issues, as it is just a minor version update. However, make sure to test the updated library thoroughly before merging the pull request. 👍
| integrity sha512-WdjvGtqJfqcCiLwtbzie53Z/H6w6dIfRHhlW832D89ySAdE5DxLAsqRhDOG0eacuAxxEB+T9sGCkVMD0fa3aBg== | ||
|
|
||
| "@react-native/assets-registry@^0.72.0": | ||
| version "0.72.0" |
There was a problem hiding this comment.
The code in the pull request looks good. The only suggestion I have is to make sure that the version number of "@react-native-community/slider" dependency is correct and up-to-date. In this case, it has been updated from version 4.4.2 to 4.4.3. You may also consider adding an emoji, such as a thumbs up 👍, to indicate that the change is approved.
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
866b9ad to
7530f9a
Compare
| "@react-native-community/slider": "4.4.4", | ||
| "@storybook/addon-actions": "^6.5.16", | ||
| "@storybook/addon-controls": "^6.5.16", | ||
| "@storybook/addon-ondevice-actions": "^6.5.6", |
There was a problem hiding this comment.
Looks good! Just a small suggestion - consider adding a brief comment within the code to highlight the reason for updating the "@react-native-community/slider" package. This will assist future developers in understanding the change more easily. 😀👍
| integrity sha512-PEq9mTEVwOh+wuBvuuIslvC8gyGHfS2G01SJJWdbb4xz+u5559iuQXqDOUxQgFuN45dM0Ut1wMFDDdawN9RTEA== | ||
|
|
||
| "@react-native/assets-registry@^0.72.0": | ||
| version "0.72.0" |
There was a problem hiding this comment.
Your version update looks good, but to enhance clarity and communication:
👍 The change in the slider package seems like a simple version bump, which should be fine if it's for an updated library. If it's linked to specific fixes or features, adding a brief note or reference link for the update in the pull request description would help.
💡 Consider specifying the reason for this particular version update to maintain transparency and documentation. It's beneficial for team members who will need to understand why this update was necessary.
Overall, your code changes seem sound! Great job!
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
7530f9a to
9b919ae
Compare
renovate
Bot
changed the title
| integrity sha512-pyUvNTvu5IfCI5abzqRfO/dd3A009RC66RXZE6t0gyOwI/j0QDlq9VZRv3rjkpuIvNTnsYj+m5BHlh0DkSYUyA== | ||
|
|
||
| "@react-native/assets-registry@^0.72.0": | ||
| version "0.72.0" |
There was a problem hiding this comment.
👍 Overall, the update looks good. However, ensure that this new version of "@react-native-community/slider@4.5.0" does not introduce breaking changes or impact compatibility with other dependencies. Also, verify if updating to this version aligns with the project's requirements. If everything checks out, you can proceed with merging the pull request. Happy coding! 😊
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
9b919ae to
724532f
Compare
renovate
Bot
changed the title
| "@react-native-community/slider": "4.5.1", | ||
| "@storybook/addon-actions": "^6.5.16", | ||
| "@storybook/addon-controls": "^6.5.16", | ||
| "@storybook/addon-ondevice-actions": "^6.5.6", |
There was a problem hiding this comment.
The change from "@react-native-community/slider": "4.4.2" to "@react-native-community/slider": "4.5.1" seems fine as it updates the version.
👍 No specific suggestions for improvement in this code segment, as updating dependencies is a common practice for fixing bugs and getting new features.
Remember to test thoroughly after updating to ensure compatibility with other parts of the project!
| integrity sha512-s3PChKU3tj/7i3z+VjxeO6n9YkoCg2omW9EYmN66bFjqsi4/aynX/nbPbFun1K97Zz8/eP5dl9YTeS0l2sLmNA== | ||
|
|
||
| "@react-native/assets-registry@^0.72.0": | ||
| version "0.72.0" |
There was a problem hiding this comment.
👍 Good work on updating the React Native Community Slider package to version 4.5.1!
Suggestions for improvement:
- Consider adding a brief comment explaining why this update was necessary or what changes are included in this version bump.
- Ensure that all relevant tests have been updated and run successfully with the new version.
- Double-check if any additional dependencies or adjustments are needed due to this version upgrade.
Keep up the good work! 🚀
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
724532f to
54fcdba
Compare
| "@react-native-community/slider": "4.5.2", | ||
| "@storybook/addon-actions": "^6.5.16", | ||
| "@storybook/addon-controls": "^6.5.16", | ||
| "@storybook/addon-ondevice-actions": "^6.5.6", |
There was a problem hiding this comment.
Great job! Your pull request looks good. Just one suggestion: consider providing a brief summary in the pull request description to outline the changes and why they were made. It helps reviewers understand the purpose of the update at a glance. 🚀
| integrity sha512-DbFyCyI7rwl0FkBkp0lzEVp+5mNfS5qU/nM2sK2aSguWhj0Odkt1aKHP2iW/ljruOhgS/O4dEixXlne4OdZJDQ== | ||
|
|
||
| "@react-native/assets-registry@^0.72.0": | ||
| version "0.72.0" |
There was a problem hiding this comment.
👍 Suggestions for improvement:
- When mentioning dependency updates, it's helpful to include a brief explanation of why the version change was necessary and any potential impacts on the project.
- Ensure that updated dependencies don't introduce breaking changes or compatibility issues with other parts of the codebase.
- Consider running test suites or checks to verify that the updated dependency doesn't cause regressions in functionality.
Overall, the pull request looks fine as long as the updated version does not introduce any unforeseen issues into the project.
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
54fcdba to
0876d48
Compare
| "@react-native-community/slider": "4.5.3", | ||
| "@storybook/addon-actions": "^6.5.16", | ||
| "@storybook/addon-controls": "^6.5.16", | ||
| "@storybook/addon-ondevice-actions": "^6.5.6", |
There was a problem hiding this comment.
🔍 Consider providing a brief reason for updating the "@react-native-community/slider" dependency to version "4.5.3" in the pull request description for better context. It helps enhance transparency and clarity for other team members reviewing the changes.
| integrity sha512-0mOdnIL3xPWYGkP7levDH3bBsjdMOiR5mQIzFrSkZznZdIfX9MvGnelNZxsWuibmkc3hczHybo7RRb6mE96H2g== | ||
|
|
||
| "@react-native/assets-registry@^0.72.0": | ||
| version "0.72.0" |
There was a problem hiding this comment.
👍 The version update from "@react-native-community/slider@4.4.2" to "@react-native-community/slider@4.5.3" looks good. Make sure to test the changes thoroughly to ensure compatibility and functionality. It's a common practice to maintain updated dependencies for bug fixes and new features.
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
0876d48 to
0e92cea
Compare
| "@react-native-community/slider": "4.5.4", | ||
| "@storybook/addon-actions": "^6.5.16", | ||
| "@storybook/addon-controls": "^6.5.16", | ||
| "@storybook/addon-ondevice-actions": "^6.5.6", |
There was a problem hiding this comment.
👍Looks good!
Consider providing a brief description of why the version of "@react-native-community/slider" was updated. It can help in tracking changes easily.
| integrity sha512-TFhwnrp0LTFG90yat8mqEOBLLMJylpnchO5F0KusH8dI0VzViIVIXOzhnx0mUVqLvRwRPbqBB0tvhxd739UhmA== | ||
|
|
||
| "@react-native/assets-registry@^0.72.0": | ||
| version "0.72.0" |
There was a problem hiding this comment.
🔍 Review Feedback:
- Consider adding a brief summary of the changes made in this PR for better context.
- The dependency update from "@react-native-community/slider@4.4.2" to version "4.5.4" looks good.
- Verify if any breaking changes are introduced between the versions and update usage accordingly.
- Ensure that existing functionalities remain unaffected by the update.
- Confirm that package-lock or yarn.lock file is updated alongside the package.json changes.
- Provide testing instructions if relevant changes have been made to ensure proper functionality.
This feedback should facilitate a comprehensive review of the pull request focusing on clarity and potential impact assessment.
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
0e92cea to
56b0678
Compare
| "@react-native-community/slider": "4.5.5", | ||
| "@storybook/addon-actions": "^6.5.16", | ||
| "@storybook/addon-controls": "^6.5.16", | ||
| "@storybook/addon-ondevice-actions": "^6.5.6", |
There was a problem hiding this comment.
👍 Update the version of "@react-native-community/slider" to "4.5.5" looks good! Ensure all related components work with this new version before merging the pull request.
| integrity sha512-x2N415pg4ZxIltArOKczPwn7JEYh+1OxQ4+hTnafomnMsqs65HZuEWcX+Ch8c5r8V83DiunuQUf5hWGWlw8hQQ== | ||
|
|
||
| "@react-native/assets-registry@^0.72.0": | ||
| version "0.72.0" |
There was a problem hiding this comment.
👍 Here are some suggestions for your pull request:
- Maintain consistency in quotation marks usage - you started with double quotes, stick to them ("@react-native-community/slider@4.5.5").
- Ensure version consistency if possible within project dependencies.
- Consider updating comments or documentation to reflect the change in slider version for transparency.
These adjustments can enhance code readability and maintain best practices.
renovate
Bot
changed the title
renovate
Bot
changed the title
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
56b0678 to
1a80205
Compare
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/react-native-community-slider-4.x
branch
from
1a80205 to
e910a86
Compare
This PR contains the following updates:
4.4.2→4.5.7Release Notes
callstack/react-native-slider (@react-native-community/slider)
v4.5.7: : React v19 and latest bugs fixesCompare Source
Hello everyone!
This release brings the following updates to the Slider:
Let's appreciate their work! 🙏
v4.5.6: : Improved custom step marker, fixes, and new channel on DiscordCompare Source
Hello community!
With this release we are happy to bring an improved custom step marker feature and some bug fixes.
The custom step marker is no longer "experimental". It has been provided with additional props and params making it more flexible and customizable. All those properties are described in the README and utilized in the example app, so please see those when using this feature for the first time or in case of any doubts. Still, we are open to further improvements or fixes to issues if you encounter any.
There are also changes and fixes done by our engaged community 💪:
by @ckknight
by @AymanHossam
by @szymonrybczak
as well as some under-the-hood changes and tweaks.
One more announcement is the new Slider's channel on our Callstack's server on Discord. The link can be found in the README, but let me drop it here as well.
Please feel invited to use this channel not only to track the activity or progress of the work on the Slider, but also to reach out in case of any doubts in usage, questions, advises, or if you think you found a bug you would like to confirm or confront with us first.
See you next time! :)
v4.5.5: : Unblock the build for v0.76 of React NativeCompare Source
Hello everyone!
This release addresses the "Multiple File not found error in React Native 0.76.0 (#662)" issue related to how React Native handles the dynamic libraries starting from v0.76 (more here).
Thanks so much to @vonovak who addressed this, before v0.76 was released, in #660 👍
v4.5.4: : BugfixesCompare Source
Dears,
With the help of community devs we were able to fix the following issues:
fixed in #639
fixed in #638
fixed in #636
fixed in #649
fixed in #657 by @chrfalch and #654 by @draggie and @vonovak
Thank you!
v4.5.3: : Fixes and QoL updatesCompare Source
Hello, community!
This release brings a lot of QoL improvements and fixes to the following issues:
by @betko in #581
fixed by @draggie in #621
resolved by @draggie in #626
fixed by @draggie in #627
fixed by @draggie in #625
fixed by @draggie in #628
as well as some "under the hood" changes, as usual.
Also,
this release is the first with @draggie, who will support Slider with maintenance.
And, as you can see on the list above, his work has already been huge and significant!
So, welcome and thank you, @draggie!
v4.5.2: : New arch measurements hotfixCompare Source
This release brings the hotfix for the last new arch measurement:
v4.5.1: : New architecture adjustments, fixes and QOL updatesCompare Source
Hello community!
As the new architecture is getting closer, libraries are prepared to meet all it's requirements and users/devs expectations that the library runs just fine when using new architecture.
This release brings such improvements and under-the-hood adjustments to the Slider, made in
PR 589: fix: new arch measurements on Android by @okwasniewski.
Also, huge THANK YOU 🙏 to all contributors for:
I have to mention, that many of these PRs and contributions were made without any specific issues, or reports or request, so I appreciate all the help!
For full changelog see: callstack/react-native-slider@v4.5.0...v4.5.1
Also:
As you may find out, there are two new props already present in the README that are marked as ☣️ experimental ☣️.
They are related to new feature(s): custom step marker, which is still under some constructions, but it's code is already on the main branch.
Feel free to use it, play with it, experiment with it, but please remember it's still to be polished.
Also, before officially released, this feature could definitely use some issue reports or feedback.
Have a nice day!
v4.5.0: : Support for React Native Vision OSCompare Source
This release introduces the Slider now supporting the React Native Vision OS,
Huge thanks to @okwasniewski delivering it in #560.
Also, please checkout the React Native Vision OS and all the work that is being done there!
v4.4.4: : iOS and Android dependencies and configurationCompare Source
This release introduces:
by @cipolleschi
by @mikehardy
As always - thank you very much to contributors! 🙏
v4.4.3: : Bugfixes and improvementsCompare Source
This release brings couple of fixes:
PR #525
PR #513
as well as some "under-the-hood" improvements:
By @TatianaKapos
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.