Fix: panic on empty environment variable name provided for set_env command

Author: sagiegurari

.buildnumber

@@ -1 +1 @@
-6
+7

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## CHANGELOG
 
+### v0.9.1 (2023-09-17)
+
+* Fix: panic on empty environment variable name provided for set_env command
+
 ### v0.9.0 (2023-09-08)
 
 * Fix: Runtime - \[Breaking Change\] Empty spread should not count as an empty string argument #354

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "duckscript_cli"
-version = "0.9.0"
+version = "0.9.1"
 authors = ["Sagie Gur-Ari <sagiegurari@gmail.com>"]
 description = "The duckscript command line executable."
 license = "Apache-2.0"
@@ -28,7 +28,7 @@ path = "src/main.rs"
 
 [dependencies]
 duckscript = { version = "^0.8.0", path = "../duckscript" }
-duckscriptsdk = { version = "^0.9.0", path = "../duckscript_sdk", default-features = false }
+duckscriptsdk = { version = "^0.9.1", path = "../duckscript_sdk", default-features = false }
 
 [features]
 tls-rustls = ["duckscriptsdk/tls-rustls"]

duckscript_cli/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "duckscriptsdk"
-version = "0.9.0"
+version = "0.9.1"
 authors = ["Sagie Gur-Ari <sagiegurari@gmail.com>"]
 description = "The duckscript SDK."
 license = "Apache-2.0"

duckscript_sdk/Cargo.toml

@@ -50,6 +50,8 @@ impl Command for CommandImpl {
             CommandResult::Error("Missing environment variable name and value.".to_string())
         } else if arguments.len() == 1 {
             CommandResult::Error("Missing environment variable value.".to_string())
+        } else if arguments[0].is_empty() {
+            CommandResult::Error("Environment variable name is empty string.".to_string())
         } else {
             if arguments[0] == "--handle" {
                 let state = get_handles_sub_state(state);
@@ -60,8 +62,10 @@ impl Command for CommandImpl {
                     Some(state_value) => match state_value {
                         StateValue::SubState(map) => {
                             for (env_key, env_value) in map {
-                                if let Ok(env_value_string) = get_as_string(env_value) {
-                                    env::set_var(&env_key, &env_value_string);
+                                if !env_key.is_empty() {
+                                    if let Ok(env_value_string) = get_as_string(env_value) {
+                                        env::set_var(&env_key, &env_value_string);
+                                    }
                                 }
                             }
 

duckscript_sdk/src/sdk/std/env/set_env/mod.rs

@@ -17,6 +17,11 @@ fn run_single_argument() {
     test::run_script_and_error(vec![create("")], "out = set_env key", "out");
 }
 
+#[test]
+fn run_empty_var_name() {
+    test::run_script_and_error(vec![create("")], "out = set_env \"\" value", "out");
+}
+
 #[test]
 fn run_set() {
     env::remove_var("DUCKSCRIPT_SDK_SET_ENV");