feat: add hash versioning for client side main.js#1656
Closed
YasharF wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds cache-busting versioning to the client-side main.js include so browsers/CDNs are less likely to serve stale JavaScript after updates.
Changes:
- Append a content-derived query parameter to
/js/main.jsin the main Pug layout. - Compute
mainJsHashat server startup and expose it viaapp.localsfor templates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
views/layout.pug |
Adds ?v= query param (from mainJsHash) to the main.js script tag. |
app.js |
Computes and sets app.locals.mainJsHash by hashing public/js/main.js. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Added by 8aa0d99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
--no-verifywas not used for the commit(s)npm run lintpassed locally without any errorsnpm testpassed locally without any errorsnpm run test:e2e:replaypassed locally without any errorsnpm run test:e2e:custom -- --project=chromium-nokey-livepassed locally without any errorsDescription
Without versioning for the client-side js files, the web browser caching or proxy caching (i.e. Cloudflare) may continue serving an outdated
main.jscausing friction during development.Screenshots of UI changes (browser) and logs/test results (console, terminal, shell, cmd)
N/A