WIP: Implement an async SqliteStorage class#37
Open
dcaliste wants to merge 4 commits into
Open
Conversation
This was referenced Dec 1, 2022
ExtendedStorage methods have been splitted between methods
dealing with a proxy (the calendar for incidences and the
notebook list) and methods working directly on the database.
The latter have been moved into a new DirectStorageInterface
class.
The previous SqliteStorage::Private class has been moved out
in separated sqlitestorage_p.{cpp,h} files. And a new
AsyncSqliteStorage class has been created using the new
SqliteStorageImpl from a worker thread. Exchange between
the worker thread and the main thread are done via
signals and are non blocking for all methods using a
proxy. For direct methods, the call are blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my latest attempt to create an async SqliteStorage backend. The purpose is to get an async access to the storage with the same ExtendedStorage API. I still need to use this new implementation in nemo-qml-plugin-calendar, so there should be still changes here and there. But I've created a new test set for this async implementation, trying to use all methods necessary for the QML plugin and they seem to pass.
It is based on the following:
As a bonus point, I've much reduced the virtual = 0 API of ExtendedStorage by introducing a polymorphic
DBLoadOperationstructure that is used internally instead of all the load*() methods.@pvuorela , as mentioned, this is still WIP and does not require any immediate reviewing. It's more to make the proposition public so you can look at it and give feedback when it suits you.