Draft: [mkcal] Add an enabled property to Notebooks.#69
Open
dcaliste wants to merge 1 commit into
Open
Conversation
pvuorela
reviewed
May 14, 2025
| /** | ||
| Set if notebook is enabled. | ||
| Disabled calendars are not shown to the user, are not synced... They are still | ||
| present in the database though. |
Member
There was a problem hiding this comment.
These comments could be slightly adjusted. We don't know if the notebooks are synced or not and shouldn't prohibit that. Also can't say for sure what are shown to user so maybe rather suggest "disabled notebooks shouldn't be shown to user".
Contributor
Author
There was a problem hiding this comment.
Good point. I rephrased the doc string to mention that it can be seen as a hint to show the notebook itself or not.
This allows to differentiate the visibility property that is user defined from the availability of given notebooks, based on external factors like account being enabled or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to differentiate the visibility property that is user defined from the availability of given notebooks, based on external factors like account being enabled or not.
@pvuorela, this is a work in progress. Basically, I think this part in mkcal is ready, but I'm slowly updating the related repos. And I still keep it as a draft since I've mainly not tested thoroughly yet. But you can see it as a proposition to continue the discussion from nemo-qml-plugin-calendar.