fix(inertia-sails): ensure locals are accessible via locals.xxx in EJS templates

[DominusKelvin]

Summary

• Fixes a bug where <%= locals.title %> in EJS templates always returned undefined, causing fallback defaults to render instead of dynamic values passed via the locals API

The Bug

When an action returns dynamic locals:

return {
  page: 'courses/view',
  props: { course },
  locals: { title: course.title, description: course.excerpt }
}

And the EJS template uses the documented locals.xxx pattern:

<title><%= locals.title || 'My App' %></title>

The rendered HTML always showed the fallback value (My App) — the dynamic value was silently ignored.

Root Cause

Sails's default EJS renderer (default-view-rendering-fn.js) creates an options.locals = {} object to hold internal helpers (blocks, layout, partial). EJS compiles templates into a function wrapped with with(data) { ... }. Inside this with block:

• title resolves to data.title → the dynamic value ✓
• locals resolves to data.locals → the Sails-created object (only has blocks, layout, partial) ✗
• locals.title → data.locals.title → undefined → falls back to default ✗

The with statement causes locals to resolve to the data.locals property (the nested Sails object) rather than the locals function parameter (which contains all the actual view data).

The Fix

Pre-populate data.locals with user-provided locals by passing them as a nested locals key alongside the spread top-level properties:

// Before
res.view(rootView, { page, ...allLocals })

// After
res.view(rootView, { page, ...allLocals, locals: { ...allLocals } })

This ensures data.locals already contains the user's values when Sails's renderer checks if (!options.locals) — it finds our pre-populated object instead of creating an empty one. The renderer then adds its internal helpers (blocks, layout, partial) to the same object, so both user values and Sails internals coexist.

Test plan

• Verify <%= locals.title %> renders dynamic values from action-level locals
• Verify <%= locals.description %> renders dynamic values from sails.inertia.local()
• Verify <%= locals.ogImage %> renders dynamic values from sails.inertia.localGlobally()
• Verify fallback values still work when no locals are set (<%= locals.title || 'Default' %>)
• Verify <%- shipwright.styles() %> and <%- shipwright.scripts() %> still work
• Verify EJS partial() and layout() helpers still work

Closes #188