fix(inertia-sails): inject inertiaContext middleware when order is not configured#194
Merged
Merged
Conversation
…t configured When sails.config.http.middleware.order is not explicitly defined (the default for all Sails apps), the hook skipped injecting the inertiaContext middleware entirely. This caused sails.inertia.share() calls in routes.before handlers to run outside AsyncLocalStorage context, silently dropping shared props. Initialize the middleware order with Sails' defaults when undefined, then inject inertiaContext before the router as intended. Closes #193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inertiaContextmiddleware not being injected whensails.config.http.middleware.orderis not explicitly defined (the default for all Sails apps)inertiaContextbefore the router as intendedContext
The
configurephase checkedmw.order && ...which skipped injection entirely whenorderwasundefined. This causedsails.inertia.share()inroutes.beforehandlers to run outside AsyncLocalStorage context, silently dropping all shared props.Test plan
inertiaContextcorrectly injected beforerouterCloses #193