Add WMS support for EPSG:3857#282
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds URL-templating enhancements for tile sources: accepts hyphenated template variables, merges default and user-provided urlData into per-tile substitution, introduces a bbox generator for EPSG:3857, and documents a WMS TileSource example; also adds ChangesURL templating & WMS BBOX
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/maplibre-gl/README.md`:
- Around line 198-202: The WMS example object literal is missing a trailing
comma after the dataRange property which makes the snippet invalid JS; update
the example by adding a comma after the dataRange value (so the property
"dataRange" ends with a comma) before the next property ("wrapX") to produce a
valid object literal and ensure the dataRange and wrapX symbols remain
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 51bd92ce-42be-404e-9c1f-6f3f1f3e636c
📒 Files selected for processing (4)
packages/gl-core/src/source/tile.tspackages/gl-core/src/source/urlData.tspackages/gl-core/src/type.tspackages/maplibre-gl/README.md
First thank you for your library !
I need to access to images from Maplibre using WMS protocole. I modified gl-core module using the same syntax as in Maplibre WMS layer. I use the {bbox-epsg-3857} pattern replace by the WMS bbox at runtime. Request example :
http://myWmsServer/wms?SERVICE=WMS&VERSION=1.3.0&REQUEST=GetMap&TRANSPARENT=true&LAYERS=myWindLayer&STYLES=default&WIDTH=256&HEIGHT=256&FORMAT=image/png&BBOX={bbox-epsg-3857}&CRS=EPSG:3857I also add a example in README of maplibre-wind
Summary by CodeRabbit
New Features
Documentation