#82

Author: etsuo

core/@model/model.ts

@@ -920,7 +920,8 @@ function save(changeSet?: { [key: string]: any } | null, options?: ReplaceOneOpt
   }
 
   if (!this.id) {
-    return Promise.reject(new SapiMissingIdErr('Model missing id field, cannot save', this));
+    return Promise.reject(new SapiMissingIdErr('Model missing id field, cannot save. Did you mean ' +
+      'to use create?', this));
   }
 
   const dbObj = changeSet || this.toDb(this);

core/@routable/routable.spec.ts

@@ -3,6 +3,7 @@ import {NextFunction, Request, Response} from 'express';
 import {ObjectID} from 'mongodb';
 import {testSapi, testUrl} from '../../spec/helpers/sakuraapi';
 import {Db, Json, Model, SakuraApiModel} from '../@model';
+import {DUPLICATE_RESOURCE} from '../helpers/http-status';
 import {Routable, routableSymbols, Route, SakuraApiRoutable} from './';
 import {IRoutableLocals} from './routable';
 import request = require('supertest');
@@ -336,6 +337,15 @@ describe('core/@Routable', () => {
       @Db({model: Contact})
       @Json()
       contact = new Contact();
+
+      @Db('email')
+      email: string;
+
+      // constructor() {
+      //   super();
+      //
+      //   this.email = `test+${new Date().getTime().toString()}@test.olivetech.net`;
+      // }
     }
 
     @Model({
@@ -386,15 +396,14 @@ describe('core/@Routable', () => {
     });
 
     beforeEach((done) => {
-      sapi
-        .listen({bootMessage: ''})
+      sapi.listen({bootMessage: ''})
+        .then(() => User.removeAll({}))
         .then(done)
         .catch(done.fail);
     });
 
     afterEach((done) => {
-      sapi
-        .close()
+      sapi.close()
         .then(done)
         .catch(done.fail);
     });
@@ -996,6 +1005,61 @@ describe('core/@Routable', () => {
             .catch(done.fail);
         });
 
+        it('sends http status 409 on MongoError: E11000', (done) => {
+          let indexName;
+
+          const userDb = sapi.dbConnections.getDb('userDb');
+          userDb
+            .collection('usersRoutableTests')
+            .createIndex({email: 1}, {unique: true})
+            .then((idxName) => {
+              indexName = idxName;
+
+              const user1 = User.fromJson({
+                email: 'test'
+              });
+
+              const user2 = User.fromJson({
+                email: 'test'
+              });
+
+              const wait = [];
+
+              wait.push(user1.create());
+              wait.push(user2.create());
+
+              return Promise.all(wait);
+            })
+            .then(() => {
+              done.fail('A MongoDB duplicate error should have been thrown, this test is invalid');
+            })
+            .catch((err) => {
+              expect(err.name).toBe('MongoError', 'Test setup should have returned a MongoError. ' +
+                `It returned ${(err || {} as any).name} instead. This test is not in a valid state`);
+              expect(err.code).toBe(11000, 'The wrong kind of mongo error was thrown, the test is in an invalid state');
+            })
+            .then(() => {
+              return request(sapi.app)
+                .post(testUrl(`/user`))
+                .type('application/json')
+                .send({
+                  email: 'test',
+                  firstName: 'george',
+                  lastName: 'washington',
+                  password: '123'
+                })
+                .expect(DUPLICATE_RESOURCE);
+            })
+            .then(() => {
+              return sapi
+                .dbConnections
+                .getDb('userDb')
+                .collection('usersRoutableTests')
+                .dropIndex(indexName);
+            })
+            .then(done)
+            .catch(done.fail);
+        });
       });
 
       describe('PUT ./model', () => {

core/@routable/routable.ts

@@ -1,9 +1,9 @@
 import {Handler, NextFunction, Request, Response} from 'express';
-
 import * as path from 'path';
 import 'reflect-metadata';
 import {IDbGetParams, modelSymbols, SakuraApiModel} from '../@model';
 import {addDefaultStaticMethods} from '../helpers';
+import {DUPLICATE_RESOURCE} from '../helpers/http-status';
 import {SanitizeMongoDB as Sanitize} from '../security/mongo-db';
 
 const debug = {
@@ -676,8 +676,33 @@ function postRouteHandler(req: Request, res: Response, next: NextFunction) {
       next();
     })
     .catch((err) => {
+      if (err.name === 'MongoError') {
+        switch (err.code) {
+          case 11000:
+            err.status = DUPLICATE_RESOURCE;
+            resLocals.send(DUPLICATE_RESOURCE, {
+              error: 'duplicate_resource'
+            });
+            break;
+          default:
+            err.status = 500;
+            resLocals.send(500, {
+              error: 'internal_server_error'
+            });
+        }
+      } else {
+        err.status = 500;
+        resLocals.send(500, {
+          error: 'internal_server_error'
+        });
+      }
+
       // TODO add some kind of error handling
-      console.log(err); // tslint:disable-line:no-console
+      if (err.status === 500) {
+        console.log(err); // tslint:disable-line:no-console
+      }
+
+      next();
     });
 }
 

core/helpers/http-status.ts

@@ -0,0 +1,3 @@
+export const DUPLICATE_RESOURCE = 409;
+export const INVALID_BODY_PARAMETER = 422;
+export const SERVER_ERROR = 500;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sakuraapi/api",
-  "version": "0.7.0-3",
+  "version": "0.7.0-4",
   "description": "MongoDB and TypeScript MEAN Stack Framework for NodeJS",
   "main": "index.js",
   "typings": "index.d.ts",
@@ -20,8 +20,8 @@
     "istanbul": "istanbul",
     "jasmine": "jasmine",
     "lint": "npm run build && npm run lint:code && npm run lint:tests",
-    "lint:code": "echo 'CODE LINT' ; npm run tslint -- -e \"**/node_modules/**/**/*.ts\" -t stylish -c tslint.json -p tsconfig.json",
-    "lint:tests": "echo 'TEST LINT' ; npm run tslint -- -e \"**/node_modules/**/**/*.ts\" -t stylish -c tslint.spec.json -p tsconfig.json",
+    "lint:code": "echo 'CODE LINT' ; npm run tslint -- -t stylish -c tslint.json -p tsconfig.json",
+    "lint:tests": "echo 'TEST LINT' ; npm run tslint -- -t stylish -c tslint.spec.json -p tsconfig.json",
     "nsp": "nsp",
     "prepublish": "npm test && npm run nsp check",
     "say:fail": "say 'fail' || echo ''",