resolves #231

Author: etsuo

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sakuraapi/core",
-  "version": "0.19.0",
+  "version": "0.19.1",
   "description": "MongoDB and TypeScript MEAN Stack Framework for NodeJS",
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",

src/core/@injectable/injectable.spec.ts

@@ -6,7 +6,10 @@ import { IRoutableLocals, Routable, Route, SapiRoutableMixin } from '../@routabl
 import { OK } from '../lib';
 import { SakuraApi } from '../sakura-api';
 import {
-  Injectable, injectableSymbols, NonInjectableConstructorParameterError, ProviderNotRegistered,
+  Injectable,
+  injectableSymbols,
+  NonInjectableConstructorParameterError,
+  ProviderNotRegistered,
   ProvidersMustBeDecoratedWithInjectableError
 } from './injectable';
 
@@ -30,8 +33,8 @@ describe('@Injectable', () => {
       });
     });
 
-    afterEach(() => {
-      sapi.close();
+    afterEach(async () => {
+      await sapi.close();
     });
 
     it('decorates @Injectable class', () => {

src/core/@model/model-operators/create.ts

@@ -30,7 +30,7 @@ export async function create(this: InstanceType<ReturnType<typeof SapiModelMixin
     throw new Error(`Database '${(constructor[modelSymbols.dbName] || {} as any).name}' not found`);
   }
 
-  this.emitBeforeCreate(context);
+  await this.emitBeforeCreate(context);
 
   const dbObj = this.toDb();
   const result = await col.insertOne(dbObj, options);

src/core/@model/model-operators/save.ts

@@ -38,7 +38,7 @@ export async function save(this: InstanceType<ReturnType<typeof SapiModelMixin>>
     throw new SapiMissingIdErr('Model missing id field, cannot save. Did you mean to use create?', this);
   }
 
-  this.emitBeforeSave(context);
+  await this.emitBeforeSave(context);
 
   const dbObj = changeSet || this.toDb(this);
   delete dbObj._id;

src/core/@routable/routable.spec.ts

@@ -3,8 +3,7 @@ import { ObjectID } from 'mongodb';
 import * as request from 'supertest';
 import { testSapi, testUrl } from '../../../spec/helpers/sakuraapi';
 import { getAllRouteHandler, getRouteHandler } from '../../handlers';
-import { Db, Json, Model, SapiModelMixin } from '../@model';
-import { Id } from '../@model/id';
+import { Db, Id, Json, Model, SapiModelMixin } from '../@model';
 import { BAD_REQUEST, DUPLICATE_RESOURCE, NOT_FOUND, OK } from '../lib';
 import { AuthenticatorPlugin, AuthenticatorPluginResult, IAuthenticator, IAuthenticatorConstructor } from '../plugins';
 import { SakuraApi } from '../sakura-api';
@@ -683,7 +682,7 @@ describe('core/@Routable', () => {
         it('without results', async (done) => {
 
           try {
-            BeforeAfterInjectRouteTestModel.removeAll({});
+            await BeforeAfterInjectRouteTestModel.removeAll({});
             const res = await request(sapi.app)
               .get(testUrl('/GetAllRouteHandlerBeforeAfterTest/beforeTest/get'))
               .expect(OK);
@@ -1767,7 +1766,7 @@ describe('core/@Routable', () => {
           const routableSuppressApiTrueTest = new RoutableSuppressApiTrueTest();
           expect(routableSuppressApiTrueTest[routableSymbols.routes].length).toBe(0);
 
-          sapi2.close();
+          await sapi2.close();
         });
 
         it('suppressess only generated endpoints that are not suppressed', async () => {

src/core/@routable/sapi-routable.mixin.spec.ts

@@ -1,13 +1,6 @@
-import {
-  NextFunction,
-  Request,
-  Response
-} from 'express';
+import { NextFunction, Request, Response } from 'express';
 import * as request from 'supertest';
-import {
-  testSapi,
-  testUrl
-} from '../../../spec/helpers/sakuraapi';
+import { testSapi, testUrl } from '../../../spec/helpers/sakuraapi';
 import { SakuraApi } from '../sakura-api';
 import { Routable } from './routable';
 import { Route } from './route';
@@ -72,7 +65,7 @@ describe('SapiRoutableMixin', () => {
         ]
       });
 
-      sapi.listen({bootMessage: ''});
+      await sapi.listen({bootMessage: ''});
 
       const result1 = await request(sapi.app)
         .get(testUrl('baseApi'))
@@ -97,7 +90,7 @@ describe('SapiRoutableMixin', () => {
       done.fail(err);
     } finally {
       if (sapi) {
-        sapi.close();
+        await sapi.close();
       }
     }
 

tslint.json

@@ -20,6 +20,7 @@
       true,
       "dev"
     ],
+    "no-floating-promises": true,
     "no-object-literal-type-assertion": false,
     "prefer-for-of": false,
     "prefer-object-spread": false,