Skip to content

Commit 77d9ba5

Browse files
committed
Show settingsServersAuthChromeMv3Limitation message again in chrome
1 parent 398f25e commit 77d9ba5

3 files changed

Lines changed: 13 additions & 0 deletions

File tree

src/_locales/en/messages.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -612,6 +612,9 @@
612612
"settingsServersPassword": {
613613
"message": "Password"
614614
},
615+
"settingsServersAuthChromeMv3Limitation": {
616+
"message": "(Unfortunately proxy server authentication is not supported by chrome through extensions api. This is "on purpose".)"
617+
},
615618
"settingsServersCancel": {
616619
"message": "Cancel"
617620
},

src/ui/code/settingsPage.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -583,6 +583,7 @@ export class settingsPage {
583583
private static populateServerProtocol() {
584584
let modal = jq("#modalModifyProxyServer");
585585
let serverInputInfo = settingsPage.readServerModel(modal);
586+
modal.find("#divServerProxy-AuthenticationMessage").hide();
586587

587588
if (serverInputInfo.protocol == "SOCKS5")
588589
modal.find("#chkServerProxyDNS-Control").show().removeClass('d-none');
@@ -594,6 +595,7 @@ export class settingsPage {
594595
else if (serverInputInfo.protocol == "SOCKS5") {
595596
if (environment.chrome) {
596597
modal.find("#chkServerProxy-Authentication").hide();
598+
modal.find("#divServerProxy-AuthenticationMessage").show();
597599
}
598600
else
599601
modal.find("#chkServerProxy-Authentication").show().removeClass('d-none');

src/ui/settings.html

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1380,7 +1380,15 @@ <h4 class="modal-title" id="modalModifyProxyServerLabel" data-localize="settings
13801380
<input type="password" id="txtServerPassword" class="form-control" />
13811381
</div>
13821382
</div>
1383+
<div class="row mb-3" id="divServerProxy-AuthenticationMessage">
1384+
<div class="form-group col chrome-only d-none">
1385+
<span data-localize="settingsServersAuthChromeMv3Limitation">(Unfortunately proxy server
1386+
authentication is not supported by chrome through extensions api. This is "on
1387+
purpose".)</span>
1388+
</div>
1389+
</div>
13831390
</div>
1391+
13841392
<div class="modal-footer">
13851393
<!-- <button type="button" class="btn btn-primary">Save changes</button>
13861394
<button type="button" class="btn btn-secondary" data-bs-dismiss="modal">Close</button> -->

0 commit comments

Comments
 (0)