Skip to content

Fix requirements file#75

Open
GilLevi wants to merge 1 commit into
salesforce:mainfrom
GilLevi:fix_req_file
Open

Fix requirements file#75
GilLevi wants to merge 1 commit into
salesforce:mainfrom
GilLevi:fix_req_file

Conversation

@GilLevi

@GilLevi GilLevi commented Dec 31, 2022

Copy link
Copy Markdown

The requirements file was not updated, casing a few small issues when running pip install -e . and trying to run the demo.

  1. torchvision version is not specified, thus pip tries to install the latest version which is not compatible with torch 1.10.0, added torchvision==0.11.1 to the requirements file which is the compatible version.
  2. The scriptlavis/models/img2prompt_models/img2prompt_vqa.py requires spacy, but it was not reflected in the requirements file resulting in an import error when running the demo, added spacy to the requirement file.
  3. spacy requires a specific version of pydantic, see issue in spacy repo here, added pydantic==1.10.2 to the requirements file.

Overall small changes, but hopefully it will save a 10 minutes of debugging to the next person:)

@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @GilLevi to sign the Salesforce.com Contributor License Agreement.

@GilLevi

GilLevi commented Dec 31, 2022

Copy link
Copy Markdown
Author

This is weird, I signed the CLA, but the PR still has the cls:missing label.
Screenshot 2022-12-31 at 16 24 13

@nick-konovalchuk

nick-konovalchuk commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

This is weird, I signed the CLA, but the PR still has the cls:missing label.

Nah, it seems to work like this all the time

@GilLevi

GilLevi commented Jan 4, 2023

Copy link
Copy Markdown
Author

Thanks @bottledmind, hope it will get merged then.

@nick-konovalchuk

Copy link
Copy Markdown
Contributor

The VQA pipeline still requires an en_core_web_sm model. I've created #77 with a hacky way of solving this issue. If you have a better idea, merge it to this PR and inform me to remove mine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants