Skip to content

Fix principal sorting to be alphabetical by name instead of ID#557

Closed
nikhil6393 wants to merge 2 commits into
salesforce:masterfrom
nikhil6393:fix-principal-sorting
Closed

Fix principal sorting to be alphabetical by name instead of ID#557
nikhil6393 wants to merge 2 commits into
salesforce:masterfrom
nikhil6393:fix-principal-sorting

Conversation

@nikhil6393

Copy link
Copy Markdown
Contributor

Resolves #238.
This pull request modifies getPrincipalIds() to list users, groups, and roles alphabetically by their name property (instead of relying on Object.keys() which defaults to ID ordering). This ensures the UI properly orders the principals page. I've also updated the related test to expect name-based sorting.

@kmcquade

Copy link
Copy Markdown
Collaborator

Thanks for this, @nikhil6393! 🙏 I've rebased your fix onto current master and resolved the conflicts in #596your commit and authorship are preserved there. Two adjustments: the test was updated to add a real name-ordering assertion (master's example dataset was enriched in #583, so the old exact-list expectation no longer applied), and the pyproject.toml uv-version hunk was dropped since master already relaxed it to >=0.11.0. Closing in favor of #596.

@kmcquade kmcquade closed this Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Principals page should list IAM roles/groups/users in alphabetical order

2 participants