Skip to content

Commit db4cc93

Browse files
committed
Fix composite action references to use absolute paths
Changed all composite action references from relative paths (./.github/actions/vscode/*) to absolute repository paths (salesforcecli/github-workflows/.github/actions/vscode/*@feat/add-vscode-extension-ci) This fixes the issue where reusable workflows called from other repos would fail because relative action paths resolve to the calling repo, not the workflow's repo. Fixes: - npm-install-with-retries - calculate-artifact-name - check-ci-status - publish-vsix All workflows now properly reference actions from the github-workflows repo when called cross-repo.
1 parent e6782a9 commit db4cc93

4 files changed

Lines changed: 15 additions & 15 deletions

File tree

.github/workflows/vscode-ci-template.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585
cache: 'npm'
8686

8787
- name: Install dependencies
88-
uses: ./.github/actions/vscode/npm-install-with-retries
88+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
8989

9090
- name: Run linting
9191
run: ${{ inputs.lint-command }}
@@ -156,7 +156,7 @@ jobs:
156156
cache: 'npm'
157157

158158
- name: Install dependencies
159-
uses: ./.github/actions/vscode/npm-install-with-retries
159+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
160160

161161
- name: Run quality tests
162162
run: npm run test:quality

.github/workflows/vscode-package.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ jobs:
8888
node-version: ${{ inputs.node-version || '22.x' }}
8989

9090
- name: Install dependencies
91-
uses: ./.github/actions/vscode/npm-install-with-retries
91+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
9292

9393
# Universal + web-target VSIXs are defined in packages/apex-lsp-vscode-extension (Wireit: package + package-web).
9494
- name: Package packages
@@ -165,7 +165,7 @@ jobs:
165165
166166
- name: Calculate artifact name
167167
id: calc-artifact-name
168-
uses: ./.github/actions/vscode/calculate-artifact-name
168+
uses: salesforcecli/github-workflows/.github/actions/vscode/calculate-artifact-name@feat/add-vscode-extension-ci
169169
with:
170170
artifact-name: ${{ inputs.artifact-name }}
171171
dry-run: ${{ inputs.dry-run }}

.github/workflows/vscode-promote-prerelease.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ jobs:
7171
node-version: '22.x'
7272

7373
- name: Install dependencies
74-
uses: ./.github/actions/vscode/npm-install-with-retries
74+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
7575

7676
- name: Find eligible nightly
7777
id: find
@@ -94,7 +94,7 @@ jobs:
9494
uses: actions/checkout@v6
9595

9696
- name: Check CI status for candidate commit
97-
uses: ./.github/actions/vscode/check-ci-status
97+
uses: salesforcecli/github-workflows/.github/actions/vscode/check-ci-status@feat/add-vscode-extension-ci
9898
with:
9999
commit-sha: ${{ needs.find-nightly-candidate.outputs.commit-sha }}
100100
token: ${{ secrets.IDEE_GH_TOKEN }}
@@ -121,7 +121,7 @@ jobs:
121121
node-version: '22.x'
122122

123123
- name: Install dependencies
124-
uses: ./.github/actions/vscode/npm-install-with-retries
124+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
125125

126126
- name: Download VSIX from nightly GitHub release
127127
env:
@@ -144,7 +144,7 @@ jobs:
144144
echo "VSIX_PATH=$VSIX_FILE" >> $GITHUB_ENV
145145
146146
- name: Publish to ${{ matrix.registry }}
147-
uses: ./.github/actions/vscode/publish-vsix
147+
uses: salesforcecli/github-workflows/.github/actions/vscode/publish-vsix@feat/add-vscode-extension-ci
148148
with:
149149
vsix-path: ${{ env.VSIX_PATH }}
150150
publish-tool: ${{ matrix.publish-tool }}

.github/workflows/vscode-publish-extensions.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
node-version: '22.x'
8888

8989
- name: Install dependencies
90-
uses: ./.github/actions/vscode/npm-install-with-retries
90+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
9191

9292
- name: Determine changes and version bumps
9393
id: changes
@@ -116,7 +116,7 @@ jobs:
116116
node-version: '22.x'
117117

118118
- name: Install dependencies
119-
uses: ./.github/actions/vscode/npm-install-with-retries
119+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
120120

121121
- name: Display Extension Release Plan
122122
env:
@@ -147,7 +147,7 @@ jobs:
147147
node-version: '22.x'
148148

149149
- name: Install dependencies
150-
uses: ./.github/actions/vscode/npm-install-with-retries
150+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
151151

152152
- name: Bump versions and tag for selected extensions
153153
env:
@@ -254,7 +254,7 @@ jobs:
254254

255255
- name: Calculate artifact name
256256
id: calc
257-
uses: ./.github/actions/vscode/calculate-artifact-name
257+
uses: salesforcecli/github-workflows/.github/actions/vscode/calculate-artifact-name@feat/add-vscode-extension-ci
258258
with:
259259
artifact-name: vsix-packages
260260
dry-run: ${{ inputs.dry-run || github.event.inputs.dry-run || 'false' }}
@@ -283,7 +283,7 @@ jobs:
283283
node-version: '22.x'
284284

285285
- name: Install dependencies
286-
uses: ./.github/actions/vscode/npm-install-with-retries
286+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
287287

288288
- name: Determine publish matrix
289289
id: matrix
@@ -398,7 +398,7 @@ jobs:
398398
echo "Found VSIX file: $VSIX_FILE"
399399
400400
- name: Publish to ${{ matrix.marketplace }}
401-
uses: ./.github/actions/vscode/publish-vsix
401+
uses: salesforcecli/github-workflows/.github/actions/vscode/publish-vsix@feat/add-vscode-extension-ci
402402
env:
403403
# Pass tokens as environment variables for better security
404404
VSCE_PERSONAL_ACCESS_TOKEN: ${{ matrix.registry == 'vsce' && secrets.VSCE_PERSONAL_ACCESS_TOKEN || '' }}
@@ -447,7 +447,7 @@ jobs:
447447
node-version: '22.x'
448448

449449
- name: Install dependencies
450-
uses: ./.github/actions/vscode/npm-install-with-retries
450+
uses: salesforcecli/github-workflows/.github/actions/vscode/npm-install-with-retries@feat/add-vscode-extension-ci
451451

452452
- name: Download VSIX artifacts
453453
uses: actions/download-artifact@v8

0 commit comments

Comments
 (0)