Skip to content

fix: handle no-op case-W-22406465 #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfeingold35 merged 2 commits into from
May 11, 2026
Merged

fix: handle no-op case-W-22406465 #156

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
936a156
fix: handle no-op case
soridalac May 7, 2026
3b99d4c
fix: remove echo and use OR
soridalac May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publishTypedoc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,6 @@ jobs:
run: |
cd docs
git add .
git diff --cached --quiet && echo "No docs changes to publish" && exit 0

@jfeingold35 jfeingold35 May 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there are changes, git diff --quiet will return a non-zero exit code, and I believe the way it's done here will crash the job. I think you'll need to combine this line with the next one to create something more like this instead:

git diff --cached --quiet || git commit -m "docs: publishing gh-pages [skip ci]" --no-verify

git commit -m 'docs: publishing gh-pages [skip ci]' --no-verify
git push origin gh-pages --no-verify