fix: review refactor

Author: ad-shreya

src/commands/devops/pipeline/activate.ts

@@ -30,11 +30,7 @@ export default class DevopsPipelineActivate extends SfCommand<ActivatePipelineRe
   public static readonly examples = messages.getMessages('examples');
 
   public static readonly flags = {
-    'target-org': Flags.requiredOrg({
-      char: 'o',
-      summary: messages.getMessage('flags.target-org.summary'),
-      required: true,
-    }),
+    'target-org': Flags.requiredOrg(),
     'api-version': Flags.orgApiVersion(),
     'pipeline-id': Flags.salesforceId({
       summary: messages.getMessage('flags.pipeline-id.summary'),

src/commands/devops/pipeline/attach-project.ts

@@ -28,11 +28,7 @@ export default class DevopsPipelineAttachProject extends SfCommand<AttachProject
   public static readonly examples = messages.getMessages('examples');
 
   public static readonly flags = {
-    'target-org': Flags.requiredOrg({
-      char: 'o',
-      summary: messages.getMessage('flags.target-org.summary'),
-      required: true,
-    }),
+    'target-org': Flags.requiredOrg(),
     'api-version': Flags.orgApiVersion(),
     'pipeline-id': Flags.salesforceId({
       summary: messages.getMessage('flags.pipeline-id.summary'),

src/commands/devops/pipeline/create.ts

@@ -28,11 +28,7 @@ export default class DevopsPipelineCreate extends SfCommand<CreatePipelineResult
   public static readonly examples = messages.getMessages('examples');
 
   public static readonly flags = {
-    'target-org': Flags.requiredOrg({
-      char: 'o',
-      summary: messages.getMessage('flags.target-org.summary'),
-      required: true,
-    }),
+    'target-org': Flags.requiredOrg(),
     'api-version': Flags.orgApiVersion(),
     name: Flags.string({
       summary: messages.getMessage('flags.name.summary'),

src/commands/devops/pipeline/stage/add.ts

@@ -30,11 +30,7 @@ export default class DevopsPipelineStageAdd extends SfCommand<AddPipelineStageRe
   public static readonly examples = messages.getMessages('examples');
 
   public static readonly flags = {
-    'target-org': Flags.requiredOrg({
-      char: 'o',
-      summary: messages.getMessage('flags.target-org.summary'),
-      required: true,
-    }),
+    'target-org': Flags.requiredOrg(),
     'api-version': Flags.orgApiVersion(),
     'pipeline-id': Flags.salesforceId({
       summary: messages.getMessage('flags.pipeline-id.summary'),

src/commands/devops/project/create.ts

@@ -28,11 +28,7 @@ export default class DevopsProjectCreate extends SfCommand<CreateProjectResult>
   public static readonly examples = messages.getMessages('examples');
 
   public static readonly flags = {
-    'target-org': Flags.requiredOrg({
-      char: 'o',
-      summary: messages.getMessage('flags.target-org.summary'),
-      required: true,
-    }),
+    'target-org': Flags.requiredOrg(),
     'api-version': Flags.orgApiVersion(),
     name: Flags.string({
       summary: messages.getMessage('flags.name.summary'),

src/commands/devops/pull-request/create.ts

@@ -34,11 +34,7 @@ export default class DevopsPullRequestCreate extends SfCommand<CreatePullRequest
   public static readonly examples = messages.getMessages('examples');
 
   public static readonly flags = {
-    'target-org': Flags.requiredOrg({
-      char: 'o',
-      summary: messages.getMessage('flags.target-org.summary'),
-      required: true,
-    }),
+    'target-org': Flags.requiredOrg(),
     'api-version': Flags.orgApiVersion(),
     'work-item-name': Flags.string({
       summary: messages.getMessage('flags.work-item-name.summary'),

src/utils/activatePipeline.ts

@@ -29,6 +29,8 @@ export type ActivatePipelineResult = {
   error?: string;
 };
 
+type ActivateResponse = { status?: string; id: string };
+
 /**
  * Activates a DevOps Center pipeline via the Connect API.
  * POST /services/data/v{version}/connect/devops/pipelines/{pipelineId}/activate
@@ -38,7 +40,7 @@ export async function activatePipeline(params: ActivatePipelineParams): Promise<
 
   const path = `/services/data/v${connection.getApiVersion()}/connect/devops/pipelines/${pipelineId}/activate`;
 
-  await connection.request({
+  const data = await connection.request<ActivateResponse>({
     method: 'POST',
     url: path,
     body: '{}',
@@ -48,6 +50,6 @@ export async function activatePipeline(params: ActivatePipelineParams): Promise<
   return {
     success: true,
     pipelineId,
-    status: 'Active',
+    status: data.status ?? 'Active',
   };
 }

src/utils/createPipeline.ts

@@ -96,15 +96,13 @@ export async function createPipeline(params: CreatePipelineParams): Promise<Crea
     payload.description = description;
   }
 
-  const response = await connection.request({
+  const data = await connection.request<ConnectPipelineResponse>({
     method: 'POST',
     url: path,
     body: JSON.stringify(payload),
     headers: { 'Content-Type': 'application/json' },
   });
 
-  const data = response as ConnectPipelineResponse;
-
   return {
     success: true,
     pipelineId: data.id,