fix: flaky auth

Author: jhefferman-sfdc

.github/workflows/test.yml

@@ -38,4 +38,3 @@ jobs:
       fail-fast: false
     with:
       os: ${{ matrix.os }}
-      nodeVersion: '20'

package.json

@@ -104,8 +104,9 @@
     "prepack": "sf-prepack",
     "prepare": "sf-install",
     "test": "wireit",
-    "test:nuts": "TS_NODE_PROJECT=test/tsconfig.json node -r dotenv/config ./node_modules/.bin/nyc mocha \"**/*.nut.ts\" --slow 4500 --timeout 600000",
-    "test:nuts:one": "TS_NODE_PROJECT=test/tsconfig.json node -r dotenv/config ./node_modules/.bin/nyc mocha --slow 4500 --timeout 600000",
+    "test:nuts": "mocha \"**/*.nut.ts\" --slow 4500 --timeout 600000",
+    "test:nuts:local": "node -r dotenv/config ./node_modules/.bin/nyc mocha \"**/*.nut.ts\" --slow 4500 --timeout 600000",
+    "test:nut:local": "node -r dotenv/config ./node_modules/.bin/nyc mocha --slow 4500 --timeout 600000",
     "test:only": "wireit",
     "unlink-lwr": "yarn unlink @lwrjs/api @lwrjs/app-service @lwrjs/asset-registry @lwrjs/asset-transformer @lwrjs/auth-middleware @lwrjs/base-view-provider @lwrjs/base-view-transformer @lwrjs/client-modules @lwrjs/config @lwrjs/core @lwrjs/dev-proxy-server @lwrjs/diagnostics @lwrjs/esbuild @lwrjs/everywhere @lwrjs/fs-asset-provider @lwrjs/fs-watch @lwrjs/html-view-provider @lwrjs/instrumentation @lwrjs/label-module-provider @lwrjs/lambda @lwrjs/legacy-npm-module-provider @lwrjs/loader @lwrjs/lwc-module-provider @lwrjs/lwc-ssr @lwrjs/markdown-view-provider @lwrjs/module-bundler @lwrjs/module-registry @lwrjs/npm-module-provider @lwrjs/nunjucks-view-provider @lwrjs/o11y @lwrjs/resource-registry @lwrjs/router @lwrjs/security @lwrjs/server @lwrjs/shared-utils @lwrjs/static @lwrjs/tools @lwrjs/types @lwrjs/view-registry lwr",
     "update-snapshots": "node --loader ts-node/esm --no-warnings=ExperimentalWarning \"./bin/dev.js\" snapshot:generate",

test/commands/lightning/dev/component-preview/hmr.nut.ts

@@ -118,7 +118,7 @@ describe('lightning preview hot module reload', () => {
     let greetingColor;
     while (greetingColor !== RED && attempt < maxAttempts) {
       // eslint-disable-next-line no-await-in-loop
-      await page.waitForTimeout(100);
+      await page.waitForTimeout(500);
       // eslint-disable-next-line no-await-in-loop
       greetingColor = await greeting.evaluate((e) => window.getComputedStyle(e).color);
       attempt++;

test/commands/lightning/dev/helpers/sessionUtils.ts

@@ -17,11 +17,44 @@ import path from 'node:path';
 import { TestSession } from '@salesforce/cli-plugins-testkit';
 import { PROJECT_PATH } from './utils.js';
 
+const SESSION_RETRIES = 3;
+const SESSION_RETRY_DELAY_MS = 5000;
+
+function isJwtAuthError(error: unknown): boolean {
+  const message = error instanceof Error ? error.message : String(error);
+  const name = error instanceof Error ? (error.constructor?.name ?? '') : '';
+  return (
+    name.includes('Jwt') ||
+    message.includes('JWT') ||
+    message.includes('client identifier invalid') ||
+    message.includes('audience is invalid')
+  );
+}
+
+/**
+ * Get the session. JWT auth is flaky hence the retries
+ *
+ * @returns
+ */
 export async function getSession(): Promise<TestSession> {
-  return TestSession.create({
-    devhubAuthStrategy: 'AUTO',
-    project: { sourceDir: PROJECT_PATH },
-  });
+  let lastError: unknown;
+  for (let attempt = 1; attempt <= SESSION_RETRIES; attempt++) {
+    try {
+      // eslint-disable-next-line no-await-in-loop
+      return await TestSession.create({
+        devhubAuthStrategy: 'AUTO',
+        project: { sourceDir: PROJECT_PATH },
+      });
+    } catch (error) {
+      lastError = error;
+      if (!isJwtAuthError(error) || attempt === SESSION_RETRIES) {
+        throw error;
+      }
+      // eslint-disable-next-line no-await-in-loop
+      await new Promise((resolve) => setTimeout(resolve, SESSION_RETRY_DELAY_MS));
+    }
+  }
+  throw lastError;
 }
 
 export function getComponentPath(session: TestSession, componentName: string) {