Skip to content

feat: update component command to return proper json result @W-19036340#459

Closed
nrkruk wants to merge 29 commits into
mainfrom
nkruk/updatePreviewCommand
Closed

feat: update component command to return proper json result @W-19036340#459
nrkruk wants to merge 29 commits into
mainfrom
nkruk/updatePreviewCommand

Conversation

@nrkruk

@nrkruk nrkruk commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Update component command to use api-version
  • Component command now returns json
  • Passing back json will allow easier integration with VSCode for the near term until we decide on how best to use a shared library across both CLI and VSCode

What issues does this PR fix or reference?

@W-19036340@

@nrkruk nrkruk self-assigned this Jul 18, 2025
@nrkruk nrkruk added the nomerge Do not merge this PR until label is removed by the author. label Jul 18, 2025
@nrkruk nrkruk requested review from a team as code owners July 18, 2025 04:19
@nrkruk nrkruk changed the title feat: update component command to use api-version / return proper json result feat: update component command to use api-version / return proper json result @W-19036340 Jul 18, 2025
@nrkruk nrkruk changed the title feat: update component command to use api-version / return proper json result @W-19036340 feat: update component command to return proper json result @W-19036340 Jul 18, 2025

@maliroteh-sf maliroteh-sf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrkruk

nrkruk commented Oct 12, 2025

Copy link
Copy Markdown
Collaborator Author

Superseded by #524

@nrkruk nrkruk closed this Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nomerge Do not merge this PR until label is removed by the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants