@W-19434936@ feat: add performance mode flag#492
Conversation
|
|
||
| Launch component preview without selecting a component | ||
|
|
||
| # flags.performance.summary |
There was a problem hiding this comment.
What if I don't pass the "performance" flag? Would I be able to see the "performance" link by clicking on the "Performance" link?
There was a problem hiding this comment.
Yes. The same operation is available in the header of the default page in the preview application.
This flag would save the user the extra step of navigating into "performance" mode" if that is their target destination.
|
|
||
| # flags.performance.summary | ||
|
|
||
| Open the component preview in performance mode |
There was a problem hiding this comment.
In the short term, I would prefer to not codify performance mode in the CLI flags. I'm not in love with the name for performance mode and I don't know that its intuitive why I would run in performance mode vs not. This seems like more of an app metadata conversation - if we are previewing a root component for an app, we should show the preview in full screen mode.
Would you be ok with just using an environment variable for now (which would still allow us to support the hackathon)?
There was a problem hiding this comment.
I'm open to other names for the flag. This name stems from the nav item in the header of the default application page(which can also change). cc @marcelinollano
I believe the CLI should be able to perform the same actions as the default application view. Today, the CLI can launch into the preview application with and without a selected component, but it cannot launch into the "performance" view.
I agree the naming is a bit unintuitive, but there is value in being able to preview a component without the "preview application chrome", especially for large components.
3 participants
What does this PR do?
Adding a flag to support launching component preview into performance mode
What issues does this PR fix or reference?
@W-19434936@