fix: address comments

Author: btrn11

src/commands/package/bundle/delete.ts

@@ -35,8 +35,6 @@ export class PackageBundleDeleteCommand extends SfCommand<BundleSaveResult> {
     'api-version': orgApiVersionFlagWithDeprecations,
     'no-prompt': Flags.boolean({
       char: 'n',
-      deprecateAliases: true,
-      aliases: ['noprompt'],
       summary: messages.getMessage('flags.no-prompt.summary'),
     }),
     bundle: Flags.string({

src/commands/package/bundle/install.ts

@@ -18,6 +18,7 @@ import {
   Flags,
   loglevel,
   orgApiVersionFlagWithDeprecations,
+  requiredHubFlagWithDeprecations,
   requiredOrgFlagWithDeprecations,
   SfCommand,
 } from '@salesforce/sf-plugins-core';
@@ -45,11 +46,7 @@ export class PackageBundlesInstall extends SfCommand<BundleSObjects.PkgBundleVer
     }),
     'target-org': requiredOrgFlagWithDeprecations,
     'api-version': orgApiVersionFlagWithDeprecations,
-    'target-dev-hub': Flags.string({
-      char: 'v',
-      summary: messages.getMessage('flags.target-dev-hub.summary'),
-      required: true,
-    }),
+    'target-dev-hub': requiredHubFlagWithDeprecations,
     wait: Flags.integer({
       char: 'w',
       summary: messages.getMessage('flags.wait.summary'),
@@ -65,28 +62,15 @@ export class PackageBundlesInstall extends SfCommand<BundleSObjects.PkgBundleVer
 
     // Get the target org connection
     const targetOrg = flags['target-org'];
-    const targetDevHubFlag = flags['target-dev-hub'];
+    const targetDevHub = flags['target-dev-hub'];
     const connection = targetOrg.getConnection(flags['api-version']);
-
-    // Check if targetDevHub is already a valid org ID (starts with 00D and is 18 characters)
-    const orgIdRegex = /^00D[a-zA-Z0-9]{15}$/;
-    let targetDevHub: string;
-
-    if (orgIdRegex.test(targetDevHubFlag)) {
-      // It's already an org ID, use it directly
-      targetDevHub = targetDevHubFlag;
-    } else {
-      // It's a username/alias, resolve it to an org and get the org ID
-      const { Org } = await import('@salesforce/core');
-      const devHubOrg = await Org.create({ aliasOrUsername: targetDevHubFlag, isDevHub: true });
-      targetDevHub = devHubOrg.getOrgId();
-    }
+    const devHubOrgId = targetDevHub.getOrgId();
 
     const options: BundleInstallOptions = {
       connection,
       project: this.project!,
       PackageBundleVersion: flags.bundle,
-      DevelopmentOrganization: targetDevHub,
+      DevelopmentOrganization: devHubOrgId,
     };
 
     // Set up lifecycle events for progress tracking
@@ -114,10 +98,9 @@ export class PackageBundlesInstall extends SfCommand<BundleSObjects.PkgBundleVer
 
     const result = await PackageBundleInstall.installBundle(connection, this.project!, {
       ...options,
-      polling: {
-        timeout: Duration.minutes(flags.wait),
-        frequency: Duration.seconds(5),
-      },
+      ...(flags.wait && flags.wait > 0
+        ? { polling: { timeout: Duration.minutes(flags.wait), frequency: Duration.seconds(5) } }
+        : undefined),
     });
 
     const finalStatusMsg = messages.getMessage('bundleInstallFinalStatus', [result.InstallStatus]);

src/commands/package/bundle/version/create.ts

@@ -117,10 +117,9 @@ export class PackageBundlesCreate extends SfCommand<BundleSObjects.PackageBundle
 
     const result = await PackageBundleVersion.create({
       ...options,
-      polling: {
-        timeout: Duration.minutes(flags.wait),
-        frequency: Duration.seconds(5),
-      },
+      ...(flags.wait && flags.wait > 0
+        ? { polling: { timeout: Duration.minutes(flags.wait), frequency: Duration.seconds(5) } }
+        : undefined),
     });
     const finalStatusMsg = messages.getMessage('bundleVersionCreateFinalStatus', [result.RequestStatus]);
     if (flags.verbose) {

src/commands/package/bundle/version/report.ts

@@ -54,16 +54,10 @@ export class PackageBundleVersionReportCommand extends SfCommand<BundleVersionRe
       throw new Error(`No bundle version found with ID: ${flags['bundle-version']}`);
     }
 
-    const massagedResults = this.massageResultsForDisplay(results);
-    this.display(massagedResults, flags.verbose);
+    this.display(results, flags.verbose);
     const componentPackages = await PackageBundleVersion.getComponentPackages(connection, flags['bundle-version']);
-    const massagedResultsWithComponentPackages = {
-      ...massagedResults,
-      componentPackages,
-    };
-
     this.displayComponentPackages(componentPackages);
-    return massagedResultsWithComponentPackages;
+    return { ...results, componentPackages };
   }
 
   private display(record: BundleSObjects.BundleVersion, verbose: boolean): void {
@@ -182,12 +176,7 @@ export class PackageBundleVersionReportCommand extends SfCommand<BundleVersionRe
     }
   }
 
-  // eslint-disable-next-line class-methods-use-this
-  private massageResultsForDisplay(results: BundleSObjects.BundleVersion): BundleSObjects.BundleVersion {
-    // For bundle versions, the data is already in the correct format
-    // Just return the results as they are
-    return results;
-  }
+  
 
   private displayComponentPackages(componentPackages: PackagingSObjects.SubscriberPackageVersion[]): void {
     if (this.jsonEnabled()) {