feat: add hidden --additional-base-packages flag to package convert

Supports 1GP-to-2GP conversions that extend a 2GP base package that
can't be auto-discovered. Hidden until core side (W-22946445) honors it.

Author: ravipanguluri

command-snapshot.json

@@ -187,6 +187,7 @@
     ],
     "flagChars": ["a", "c", "f", "k", "m", "p", "s", "v", "w", "x"],
     "flags": [
+      "additional-base-packages",
       "api-version",
       "build-instance",
       "code-coverage",
@@ -419,6 +420,7 @@
       "code-coverage",
       "definition-file",
       "flags-dir",
+      "generate-pkg-zip",
       "installation-key",
       "installation-key-bypass",
       "json",
@@ -440,8 +442,7 @@
       "version-description",
       "version-name",
       "version-number",
-      "wait",
-      "generate-pkg-zip"
+      "wait"
     ],
     "plugin": "@salesforce/plugin-packaging"
   },

messages/package_convert.md

@@ -93,3 +93,11 @@ Calculate and store the code coverage percentage by running the packaged Apex te
 # flags.code-coverage.description
 
 Before you can promote and release a managed package version, the Apex code must meet a minimum 75% code coverage requirement.
+
+# flags.additional-base-packages.summary
+
+Comma-separated list of second-generation base package version IDs (starts with 04t) that the package being converted extends.
+
+# flags.additional-base-packages.description
+
+Specify this flag when you convert a first-generation managed package that extends a second-generation base package. List the subscriber package version IDs (starts with 04t) of the base packages; they're installed before the converted package version. Most conversions don't need this flag because dependencies are detected automatically.

src/commands/package/convert.ts

@@ -106,6 +106,13 @@ export class PackageConvert extends SfCommand<PackageVersionCreateRequestResult>
       description: messages.getMessage('flags.code-coverage.description'),
       default: false,
     }),
+    // Narrow flag for 1GP-extends-2GP conversions where the 2GP base package can't be
+    // auto-discovered. Hidden until the core side (W-22946445) honors it.
+    'additional-base-packages': Flags.string({
+      summary: messages.getMessage('flags.additional-base-packages.summary'),
+      description: messages.getMessage('flags.additional-base-packages.description'),
+      hidden: true,
+    }),
   };
 
   public async run(): Promise<PackageVersionCreateRequestResult> {
@@ -142,6 +149,7 @@ export class PackageConvert extends SfCommand<PackageVersionCreateRequestResult>
         seedMetadata: flags['seed-metadata'] as string,
         patchversion: flags['patch-version'] as string,
         codecoverage: flags['code-coverage'] as boolean,
+        additionalBasePackages: parseAdditionalBasePackages(flags['additional-base-packages']),
       },
       this.project
     );
@@ -187,3 +195,18 @@ export class PackageConvert extends SfCommand<PackageVersionCreateRequestResult>
     }
   }
 }
+
+/**
+ * Parse the comma-separated --additional-base-packages flag into a list of subscriber package
+ * version IDs. Existence and validity checks are owned by the server.
+ */
+function parseAdditionalBasePackages(value: string | undefined): string[] | undefined {
+  if (!value) {
+    return undefined;
+  }
+  const ids = value
+    .split(',')
+    .map((id) => id.trim())
+    .filter((id) => id.length > 0);
+  return ids.length > 0 ? ids : undefined;
+}

test/commands/package/packageConvert.test.ts

@@ -135,6 +135,48 @@ describe('package:convert', () => {
     expect(callArgs.codecoverage).to.equal(true);
     expect(result).to.deep.equal(pvc);
   });
+  it('parses comma-separated --additional-base-packages into an array of 04t ids', async () => {
+    const pvc = {
+      Branch: 'main',
+      ConvertedFromVersionId: null,
+      CreatedBy: '133',
+      CreatedDate: '2022-08-31 11:48',
+      Error: [],
+      HasMetadataRemoved: false,
+      HasPassedCodeCoverageCheck: false,
+      Id: '08c3i000000bmf6AAA',
+      Package2Id: '0Ho3i000000Gmj6CAC',
+      Package2Name: 'MyTestPackage',
+      Package2VersionId: '05i3i000000bllhAAA',
+      Status: Package2VersionStatus.inProgress,
+      SubscriberPackageVersionId: '04t3i000002OUEkAAO',
+      Tag: '',
+      CodeCoverage: null,
+      VersionNumber: null,
+      TotalNumberOfMetadataFiles: null,
+      TotalSizeOfMetadataFiles: null,
+    } satisfies PackageVersionCreateRequestResult;
+
+    convertStub.restore();
+    convertStub = $$.SANDBOX.stub(Package, 'convert').resolves(pvc);
+    const cmd = new PackageConvert(
+      [
+        '-p',
+        CONVERTED_FROM_PACKAGE_ID,
+        '--installation-key',
+        INSTALL_KEY,
+        '-v',
+        'test@user.com',
+        '--additional-base-packages',
+        '04t3i000002OUEkAAO, 04t3i000002OUElAAO',
+      ],
+      config
+    );
+    stubSpinner(cmd);
+    await cmd.run();
+    const callArgs = convertStub.getCall(0).args[2] as ConvertPackageOptions;
+    expect(callArgs.additionalBasePackages).to.deep.equal(['04t3i000002OUEkAAO', '04t3i000002OUElAAO']);
+  });
   it('starts package version create request (error)', async () => {
     const pvc = {
       Branch: 'main',