W-17561980 CLI Command to Display Dependencies by MimiRaiSalesforce · Pull Request #1011 · salesforcecli/plugin-packaging

MimiRaiSalesforce · 2025-07-23T16:29:31Z

@W-17561980@

Summary

Include sf package version displaydependencies command
Include --verbose and --edge-direction flags

jshackell-sfdc

See my small edits. But the messages look great overall, which is why I also approved.

jshackell-sfdc · 2025-07-23T16:59:03Z

+
+# examples
+
+- Display the dependency graph for a package version with the specified alias, using your default Dev Hub org, and the default edge-direction:


Suggested change

- Display the dependency graph for a package version with the specified alias, using your default Dev Hub org, and the default edge-direction:

- Display the dependency graph for a package version with the specified alias, using your default Dev Hub org and the default edge-direction:

jshackell-sfdc · 2025-07-23T16:59:31Z

+
+  <%= config.bin %> <%= command.id %> --package package_version_alias
+
+- Display the dependency graph for a package version with the specified ID, display the graph using a root-last edge direction. Use the Dev Hub org with username devhub@example.com:


Suggested change

- Display the dependency graph for a package version with the specified ID, display the graph using a root-last edge direction. Use the Dev Hub org with username devhub@example.com:

- Display the dependency graph for a package version with the specified ID and display the graph using a root-last edge direction. Use the Dev Hub org with username devhub@example.com:

jshackell-sfdc · 2025-07-23T16:59:57Z

+
+  <%= config.bin %> <%= command.id %> --package 04t... --edge-direction root-last --target-dev-hub devhub@example.com
+
+- Display the dependency graph of a version create request with the specified ID, using your default Dev Hub org, and the default edge-direction:


Suggested change

- Display the dependency graph of a version create request with the specified ID, using your default Dev Hub org, and the default edge-direction:

- Display the dependency graph of a version create request with the specified ID, using your default Dev Hub org and the default edge-direction:

jshackell-sfdc · 2025-07-23T17:02:34Z

+
+# flags.package.description
+
+Before running this command, update your sfdx-project.json file to specify the calculateTransitiveDependencies attribute, and set the value to true. This command returns GraphViz code, which can be compiled to a graph using DOT code, or another graph visualization software.


Suggested change

Before running this command, update your sfdx-project.json file to specify the calculateTransitiveDependencies attribute, and set the value to true. This command returns GraphViz code, which can be compiled to a graph using DOT code, or another graph visualization software.

Before running this command, update your sfdx-project.json file to specify the calculateTransitiveDependencies attribute, and set the value to true. This command returns GraphViz code, which can be compiled to a graph using DOT code or another graph visualization software.

jshackell-sfdc · 2025-07-23T17:37:44Z

+
+# flags.edge-direction.description
+
+A root-first graph declares the root as the package that must be installed last. A root-last graph is the reverse order of root-first. If you specify --edge-direction=root-last, the graph displays the packages in the order they must be installed. The root starts with the farthest leaf of the package dependencies, and ends with the base package, which must be installed last.


Suggested change

A root-first graph declares the root as the package that must be installed last. A root-last graph is the reverse order of root-first. If you specify --edge-direction=root-last, the graph displays the packages in the order they must be installed. The root starts with the farthest leaf of the package dependencies, and ends with the base package, which must be installed last.

A root-first graph declares the root as the package that must be installed last. A root-last graph is the reverse order of root-first. If you specify "--edge-direction root-last", the graph displays the packages in the order they must be installed. The root starts with the farthest leaf of the package dependencies and ends with the base package, which must be installed last.

luop90 · 2025-07-25T18:04:17Z

+import { requiredHubFlag } from '../../../utils/hubFlag.js';
+import { maybeGetProject } from '../../../utils/getProject.js';
+
+// Import i18n messages


I don't think this comment is strictly necessary

luop90 · 2025-07-25T18:06:08Z

+      expect(result).to.contain('strict digraph G {');
+      const hasValidNode = result.includes('node_');
+      expect(hasValidNode).to.be.true;
+      expect(result).to.match(/label="[^"]*@\d\.\d\.\d\.\d"/);


When using regex like this, I recommend making these well-named string constants to help document what you're looking for. In this case, it's looking like the version number, so maybe VERSION_NUMBER_REGEX as a name.

I added the following new constants NODE_LABEL_REGEX = /label="[^"]*@\d+\.\d+\.\d+\.\d+"/ and EDGE_REGEX = /\t node_\w+ -> node_\w+/g

luop90 · 2025-07-25T18:07:00Z

+      const resultRootLast = execCmd(commandRootLast, { ensureExitCode: 0 }).shellOutput.stdout;
+      expect(resultRootFirst).to.contain('strict digraph G {');
+      expect(resultRootLast).to.contain('strict digraph G {');
+      const hasMultipleNodes = ((resultRootFirst.match(/node_/g) && resultRootLast.match(/node_/g)) || []).length > 1;


I don't understand why the || [] is needed?

We need the empty array to find the length if the results return null.

g bransch 'main' of https://github.com/salesforcecli/plugin-packaging into t/managed-packaging/W-17561980/display-dependency-graph # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

into t/managed-packaging/W-17561980/display-dependency-graph

MimiRaiSalesforce added 3 commits July 14, 2025 11:22

feat: implement display dependencies CLI command

2da5ad1

feat: added in displaydependencies cli command

1fa2e94

feat: display dependencies

c8d1bf5

MimiRaiSalesforce requested a review from a team as a code owner July 23, 2025 16:29

jshackell-sfdc approved these changes Jul 23, 2025

View reviewed changes

feat: updated messages for displaydependencies command

a7661fb

luop90 reviewed Jul 25, 2025

View reviewed changes

MimiRaiSalesforce added 5 commits July 28, 2025 09:00

feat: updated comments and created constant variables for regex

6e1fde3

Merge branch 'main' of https://github.com/salesforcecli/plugin-packaging

fd88741

into t/managed-packaging/W-17561980/display-dependency-graph

feat: merged from main

6d09006

feat: updated snapshot

4095c18

This was referenced Jul 29, 2025

W-17561980 Verified GPG Signing CLI Command to Display Dependencies #1017

Closed

W-17561980 Complete CLI Command to Display Dependencies #1018

Merged

MimiRaiSalesforce closed this Jul 29, 2025

MimiRaiSalesforce deleted the t/managed-packaging/W-17561980/display-dependency-graph branch July 29, 2025 16:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

W-17561980 CLI Command to Display Dependencies#1011

W-17561980 CLI Command to Display Dependencies#1011
MimiRaiSalesforce wants to merge 9 commits into
mainfrom
t/managed-packaging/W-17561980/display-dependency-graph

MimiRaiSalesforce commented Jul 23, 2025 •

edited

Loading

Uh oh!

jshackell-sfdc left a comment

Uh oh!

jshackell-sfdc Jul 23, 2025

Uh oh!

jshackell-sfdc Jul 23, 2025

Uh oh!

jshackell-sfdc Jul 23, 2025

Uh oh!

jshackell-sfdc Jul 23, 2025

Uh oh!

jshackell-sfdc Jul 23, 2025

Uh oh!

luop90 Jul 25, 2025

Uh oh!

luop90 Jul 25, 2025

Uh oh!

MimiRaiSalesforce Jul 28, 2025

Uh oh!

luop90 Jul 25, 2025

Uh oh!

MimiRaiSalesforce Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		# examples

		- Display the dependency graph for a package version with the specified alias, using your default Dev Hub org, and the default edge-direction:


		<%= config.bin %> <%= command.id %> --package package_version_alias

		- Display the dependency graph for a package version with the specified ID, display the graph using a root-last edge direction. Use the Dev Hub org with username devhub@example.com:


		<%= config.bin %> <%= command.id %> --package 04t... --edge-direction root-last --target-dev-hub devhub@example.com

		- Display the dependency graph of a version create request with the specified ID, using your default Dev Hub org, and the default edge-direction:


		# flags.package.description

		Before running this command, update your sfdx-project.json file to specify the calculateTransitiveDependencies attribute, and set the value to true. This command returns GraphViz code, which can be compiled to a graph using DOT code, or another graph visualization software.


		# flags.edge-direction.description

		A root-first graph declares the root as the package that must be installed last. A root-last graph is the reverse order of root-first. If you specify --edge-direction=root-last, the graph displays the packages in the order they must be installed. The root starts with the farthest leaf of the package dependencies, and ends with the base package, which must be installed last.

Uh oh!

Conversation

MimiRaiSalesforce commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

jshackell-sfdc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MimiRaiSalesforce commented Jul 23, 2025 •

edited

Loading