@W-19441295 Merge bundles CLI - plugin side#1038
Merged
Merged
Conversation
decided to to add tests yet because package create only has nut and we don't have delete yet
changed comments, added test for bundle create
near copy and paste of package list command unit test based off of bundle create
…-18671326/Package-Bundle-Create-command feat: added bundle create
changed bundles to bundle in order to generate proper command
additionally updates messages
…-18762471/Package-Bundle-List-command feat: created bundle list command
additionally made unit tests, and list, and report features
…-18782182/Package-Bundle-Version-Create-command feat: created bundle version create
…-18839621/Package-Bundle-Version-List-command feat: added package version list
…-18854587/Package-Bundle-Version-Report-command T/packaging distribution/w 18854587/package bundle version report command
additionally made package bundle version create report flags make more sense
…distribution/W-18909971/Package-Bundle-Delete
…-18909971/Package-Bundle-Delete T/packaging distribution/w 18909971/package bundle delete
…distribution/W-18927681/Package-Bundle-Install
…-18927681/Package-Bundle-Install feat: created pakcage bundle install command
…W-19015989/Hide-Commands fix: hide bundles and state beta
This is a silly workaround but it works and will be removed in the future
…W-19170618/Bug-Fixes T/packaging distribution/w 19170618/bug fixes
btrn11
changed the title
WillieRuemmele
requested changes
Sep 5, 2025
| const result = await PackageBundleVersion.create({ | ||
| ...options, | ||
| polling: { | ||
| timeout: Duration.minutes(flags.wait), |
Contributor
There was a problem hiding this comment.
wait isn't a required flag, so this value can be undefined and lead to issues
| } | ||
|
|
||
| // eslint-disable-next-line class-methods-use-this | ||
| private massageResultsForDisplay(results: BundleSObjects.BundleVersion): BundleSObjects.BundleVersion { |
Contributor
There was a problem hiding this comment.
why do you need this method?
| 'no-prompt': Flags.boolean({ | ||
| char: 'n', | ||
| deprecateAliases: true, | ||
| aliases: ['noprompt'], |
Contributor
There was a problem hiding this comment.
there's a few flags with aliases like this, where we're already deprecating the aliases as they're introduced? why even add the alias?
Contributor
There was a problem hiding this comment.
@btrn11 - there's still 5 new flags being added, with deprecateAliases:true - let's remove all of them
Comment on lines
+72
to
+81
| const orgIdRegex = /^00D[a-zA-Z0-9]{15}$/; | ||
| let targetDevHub: string; | ||
|
|
||
| if (orgIdRegex.test(targetDevHubFlag)) { | ||
| // It's already an org ID, use it directly | ||
| targetDevHub = targetDevHubFlag; | ||
| } else { | ||
| // It's a username/alias, resolve it to an org and get the org ID | ||
| const { Org } = await import('@salesforce/core'); | ||
| const devHubOrg = await Org.create({ aliasOrUsername: targetDevHubFlag, isDevHub: true }); |
Contributor
There was a problem hiding this comment.
There should already be a targetDevHub flag, similar to requiredOrgFlagWithDeprecations that'll do all of this for you requiredHubFlagWithDeprecations
WillieRuemmele
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@W-19441295@
What does this PR do?
What issues does this PR fix or reference?