chore: cover null cases for test

Author: mshanemc

package.json

@@ -42,7 +42,7 @@
     "shx": "0.3.4",
     "sinon": "10.0.0",
     "ts-node": "^10.0.0",
-    "typescript": "^4.9.3"
+    "typescript": "^4.9.5"
   },
   "config": {},
   "engines": {
@@ -110,4 +110,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}

test/commands/sobject/list.test.ts

@@ -81,6 +81,7 @@ describe('force:schema:sobject:list', () => {
           sobjects: [],
         });
       }
+      throw new Error('Unexpected request');
     };
     const cmd = new SObjectList(['-u', 'testUser@test.com'], config);
 

test/schema.nut.ts

@@ -5,9 +5,11 @@
  * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
  */
 import * as path from 'path';
+import { strict as assert } from 'node:assert';
 import { expect } from 'chai';
 import { DescribeSObjectResult } from 'jsforce';
 import { TestSession, execCmd } from '@salesforce/cli-plugins-testkit';
+import { SObjectListResult } from '../src/commands/sobject/list';
 
 let session: TestSession;
 
@@ -63,32 +65,35 @@ describe('verifies all commands run successfully ', () => {
 
   describe('list command', () => {
     it('requests all objects by default', () => {
-      const output = execCmd<string[]>('force:schema:sobject:list --json', { ensureExitCode: 0 }).jsonOutput;
-      expect(output.result).to.have.length.greaterThan(1);
-      allObjects = output.result;
+      const result = execCmd<SObjectListResult>('force:schema:sobject:list --json', { ensureExitCode: 0 }).jsonOutput
+        ?.result;
+      assert(result?.length);
+      expect(result).to.have.length.greaterThan(1);
+      allObjects = result;
     });
 
     it('requests all objects explicity', () => {
-      const output = execCmd<string[]>('force:schema:sobject:list --json --sobjecttypecategory ALL', {
+      const result = execCmd<SObjectListResult>('force:schema:sobject:list --json --sobjecttypecategory ALL', {
         ensureExitCode: 0,
-      }).jsonOutput;
-      expect(output.result).to.have.length(allObjects.length);
-      allObjects = output.result;
+      }).jsonOutput?.result;
+      assert(result);
+      expect(result).to.have.length(allObjects.length);
+      allObjects = result;
     });
 
     it('requests standard objects', () => {
-      const output = execCmd<string[]>('force:schema:sobject:list --json --sobjecttypecategory STANDARD', {
+      const result = execCmd<SObjectListResult>('force:schema:sobject:list --json --sobjecttypecategory STANDARD', {
         ensureExitCode: 0,
-      }).jsonOutput;
+      }).jsonOutput?.result;
       // all the objects are standard in a vanilla scratch org
-      expect(output.result).to.have.length(allObjects.length);
+      expect(result).to.have.length(allObjects.length);
     });
 
     it('requests custom objects but finds none in vanilla scratch org', () => {
-      const output = execCmd<string[]>('force:schema:sobject:list --json --sobjecttypecategory CUSTOM', {
+      const result = execCmd<SObjectListResult>('force:schema:sobject:list --json --sobjecttypecategory CUSTOM', {
         ensureExitCode: 0,
-      }).jsonOutput;
-      expect(output.result).to.have.length(0);
+      }).jsonOutput?.result;
+      expect(result).to.have.length(0);
     });
 
     it('no errors on non-json commands', () => {
@@ -104,14 +109,14 @@ describe('verifies all commands run successfully ', () => {
       const output = execCmd<DescribeSObjectResult>('force:schema:sobject:describe --sobjecttype Account --json', {
         ensureExitCode: 0,
       }).jsonOutput;
-      expect(output.result).to.include.keys(objectDescribeKeys);
+      expect(output?.result).to.include.keys(objectDescribeKeys);
     });
 
     it('describes ApexClass via toolingApi', () => {
       const output = execCmd<DescribeSObjectResult>('force:schema:sobject:describe --sobjecttype ApexClass -t --json', {
         ensureExitCode: 0,
       }).jsonOutput;
-      expect(output.result).to.include.keys(objectDescribeKeys);
+      expect(output?.result).to.include.keys(objectDescribeKeys);
     });
 
     it('no errors on non-json commands', () => {

yarn.lock

@@ -7189,11 +7189,16 @@ typedoc@0.22.18:
     minimatch "^5.1.0"
     shiki "^0.10.1"
 
-typescript@^4.1.3, typescript@^4.6.4, typescript@^4.9.3, typescript@~4.9.3:
+typescript@^4.1.3, typescript@^4.6.4, typescript@~4.9.3:
   version "4.9.4"
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.4.tgz#a2a3d2756c079abda241d75f149df9d561091e78"
   integrity sha512-Uz+dTXYzxXXbsFpM86Wh3dKCxrQqUcVMxwU54orwlJjOpO3ao8L7j5lH+dWfTwgCwIuM9GQ2kvVotzYJMXTBZg==
 
+typescript@^4.9.5:
+  version "4.9.5"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.5.tgz#095979f9bcc0d09da324d58d03ce8f8374cbe65a"
+  integrity sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g==
+
 uglify-js@^3.1.4:
   version "3.15.3"
   resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.15.3.tgz#9aa82ca22419ba4c0137642ba0df800cb06e0471"