Checks failed

Author: salilg-eng

Storage/tests/System/ManageBucketsTest.php

@@ -605,6 +605,13 @@ public function encryptionEnforcementConfigs()
         ];
     }
 
+    /**
+     * Creates a bucket with IP filter disabled.
+     *
+     * @group storage-ipfilter
+     *
+     * @return Bucket
+     */
     public function testCreateBucketWithIpFilterDisabled()
     {
         $projectId = self::getProjectId(getenv('GOOGLE_CLOUD_PHP_TESTS_KEY_PATH'));
@@ -647,7 +654,14 @@ public function testCreateBucketWithIpFilterDisabled()
     }
 
     /**
+     * Deletes an IP from the bucket IP filter.
+     *
      * @depends testCreateBucketWithIpFilterDisabled
+     * @group   storage-ipfilter
+     *
+     * @param Bucket $bucket The bucket.
+     *
+     * @return void
      */
     public function testDeleteBucketIpFilter(Bucket $bucket)
     {
@@ -665,6 +679,13 @@ public function testDeleteBucketIpFilter(Bucket $bucket)
         $this->assertArrayNotHasKey('allowedIpCidrRanges', $info['ipFilter']['publicNetworkSource']);
     }
 
+    /**
+     * Tests creating a bucket with invalid IP filter fails.
+     *
+     * @group storage-ipfilter
+     *
+     * @return void
+     */
     public function testCreateBucketWithInvalidIpFilterFails()
     {
         $this->expectException(BadRequestException::class);

Storage/tests/Unit/BucketTest.php

@@ -808,7 +808,11 @@ public function testGetBucketWithIpFilter()
             $info['ipFilter']['publicNetworkSource']['allowedIpCidrRanges']
         );
     }
-
+    /**
+     * Tests disabling a bucket IP filter.
+     *
+     * @return void
+     */
     public function testDisableBucketIpFilter()
     {
         $ipFilterConfig = [
@@ -834,7 +838,11 @@ public function testDisableBucketIpFilter()
         $this->assertArrayHasKey('ipFilter', $info);
         $this->assertEquals('Disabled', $info['ipFilter']['mode']);
     }
-
+    /**
+     * Tests deleting an IP from a bucket IP filter.
+     *
+     * @return void
+     */
     public function testDeleteBucketIpFilter()
     {
         $ipFilterConfig = [