Fixing test Suite

Author: salilg-eng

Storage/tests/System/ManageBucketsTest.php

@@ -177,7 +177,9 @@ public function testCreateBucketWithLifecycleDeleteRule(array $rule, $isError =
         $lifecycle->addDeleteRule($rule);
 
         $bucket = self::createBucket(
-            self::$client, uniqid(self::TESTING_PREFIX), [
+            self::$client,
+            uniqid(self::TESTING_PREFIX),
+            [
             'lifecycle' => $lifecycle
             ]
         );
@@ -204,7 +206,9 @@ public function testCreateBucketWithLifecycleAbortIncompleteMultipartUploadRule(
         $lifecycle->addAbortIncompleteMultipartUploadRule($rule);
 
         $bucket = self::createBucket(
-            self::$client, uniqid(self::TESTING_PREFIX), [
+            self::$client,
+            uniqid(self::TESTING_PREFIX),
+            [
             'lifecycle' => $lifecycle
             ]
         );
@@ -374,7 +378,8 @@ public function testIam()
         $policy = $iam->reload();
 
         $newBinding = array_filter(
-            $policy['bindings'], function ($binding) use ($role) {
+            $policy['bindings'],
+            function ($binding) use ($role) {
                 return ($binding['role'] === $role);
             }
         );
@@ -435,7 +440,9 @@ public function testBucketLocationType($storageClass, $location, $expectedLocati
     {
         $bucketName = uniqid(self::TESTING_PREFIX);
         $bucket = self::createBucket(
-            self::$client, $bucketName, [
+            self::$client,
+            $bucketName,
+            [
             'storageClass' => $storageClass,
             'location' => $location,
             'retentionPolicy' => [
@@ -459,7 +466,8 @@ public function testBucketLocationType($storageClass, $location, $expectedLocati
         $buckets = iterator_to_array(self::$client->buckets());
         $listBucketBucket = current(
             array_filter(
-                $buckets, function ($bucket) use ($bucketName) {
+                $buckets,
+                function ($bucket) use ($bucketName) {
                     return $bucket->name() === $bucketName;
                 }
             )
@@ -668,7 +676,7 @@ public function testDeleteBucketIpFilter(Bucket $bucket)
         $ipFilterConfig = [
             'mode' => 'Disabled',
             'publicNetworkSource' => [
-                'allowedIpCidrRanges' => [] 
+                'allowedIpCidrRanges' => []
             ],
             'allowAllServiceAgentAccess' => true
         ];

Storage/tests/Unit/BucketTest.php

@@ -206,7 +206,8 @@ public function testUploadResumableFinalChunkHashes()
                 function ($request) {
                     return $request->getMethod() === 'POST';
                 }
-            ), Argument::any()
+            ),
+            Argument::any()
         )->willReturn(new \GuzzleHttp\Psr7\Response(200, ['Location' => $resumeUri]));
 
         // Intermediate chunk (PUT) - Should NOT have X-Goog-Hash
@@ -217,7 +218,8 @@ function ($request) {
                     && $request->getHeaderLine('Content-Range') === 'bytes 0-5/12'
                     && !$request->hasHeader('X-Goog-Hash');
                 }
-            ), Argument::any()
+            ),
+            Argument::any()
         )->willReturn(new \GuzzleHttp\Psr7\Response(308, ['Range' => 'bytes=0-5']));
 
         // FINAL chunk (PUT) - MUST HAVE X-Goog-Hash
@@ -228,7 +230,8 @@ function ($request) use ($hash) {
                     && $request->getHeaderLine('Content-Range') === 'bytes 6-11/12'
                     && $request->getHeaderLine('X-Goog-Hash') === $hash;
                 }
-            ), Argument::any()
+            ),
+            Argument::any()
         )->willReturn(
             new \GuzzleHttp\Psr7\Response(200, [], '{"name":"' . $name . '","generation":"1"}')
         );
@@ -252,7 +255,8 @@ function ($request) use ($hash) {
 
         $bucket = $this->getBucket();
         $object = $bucket->upload(
-            $data, [
+            $data,
+            [
             'name' => $name,
             'resumable' => true,
             'chunkSize' => 6,
@@ -275,7 +279,8 @@ public function testInstantiateObjectWithOptions()
         $bucket = $this->getBucket();
 
         $object = $bucket->object(
-            'peter-venkman.jpg', [
+            'peter-venkman.jpg',
+            [
             'generation' => '5',
             'encryptionKey' => 'abc',
             'encryptionKeySHA256' => '123'
@@ -316,7 +321,8 @@ public function testGetsObjectsWithToken()
                         'generation' => 'abc'
                     ]
                 ]
-                ], [
+                ],
+                [
                 'items' => [
                     [
                         'name' => 'file2.txt',
@@ -450,7 +456,9 @@ public function testComposesObjects(
         $bucket = $this->getBucket();
 
         $object = $bucket->compose(
-            $objects, $destinationObject, [
+            $objects,
+            $destinationObject,
+            [
             'predefinedAcl' => $acl,
             'metadata' => $metadata
             ]
@@ -484,7 +492,9 @@ public function testComposeWithDeleteSourceObjects()
         $bucket = $this->getBucket();
 
         $object = $bucket->compose(
-            ['file1.txt', 'file2.txt'], $destinationObject, [
+            ['file1.txt', 'file2.txt'],
+            $destinationObject,
+            [
             'predefinedAcl' => $acl,
             'deleteSourceObjects' => true
             ]
@@ -516,7 +526,9 @@ public function testComposeWithDeleteSourceObjectsFalse()
         $bucket = $this->getBucket();
 
         $object = $bucket->compose(
-            ['file1.txt', 'file2.txt'], $destinationObject, [
+            ['file1.txt', 'file2.txt'],
+            $destinationObject,
+            [
             'predefinedAcl' => $acl,
             'deleteSourceObjects' => false
             ]
@@ -548,7 +560,9 @@ public function testComposeWithDeleteSourceObjectsNull()
         $bucket = $this->getBucket();
 
         $object = $bucket->compose(
-            ['file1.txt', 'file2.txt'], $destinationObject, [
+            ['file1.txt', 'file2.txt'],
+            $destinationObject,
+            [
             'predefinedAcl' => $acl,
             'deleteSourceObjects' => null
             ]
@@ -619,7 +633,8 @@ public function testUpdateAutoclassConfig($terminalStorageClass)
             ],
         ];
         $expectedInfo = array_merge_recursive(
-            $autoclassConfig, ['autoclass' => [
+            $autoclassConfig,
+            ['autoclass' => [
             'toggleTime' => '2022-09-18T01:01:01.045123456Z',
             'terminalStorageClassUpdateTime' => '2022-09-18T01:01:01.045123456Z'
             ]]
@@ -983,7 +998,8 @@ public function testCreateObjectWithValidContexts()
         $this->connection->insertObject(Argument::any())
             ->willReturn($this->resumableUploader->reveal());
         $object = $this->getBucket()->upload(
-            'upload', [
+            'upload',
+            [
             'name' => 'data.txt',
             'contexts' => $contexts
             ]
@@ -1094,7 +1110,8 @@ public function testCopyObjectWithMetadataOverrides()
             ->willReturn($destinationObject->reveal());
 
         $response = $sourceObject->reveal()->copy(
-            self::BUCKET_NAME, [
+            self::BUCKET_NAME,
+            [
             'name' => $destFileName,
             'metadata' => $metadata
             ]
@@ -1409,10 +1426,12 @@ private function getBucketForSigning(
         $this->connection->projectId()->willReturn(self::PROJECT_ID);
 
         return TestHelpers::stub(
-            Bucket::class, [
+            Bucket::class,
+            [
             $this->connection->reveal(),
             self::BUCKET_NAME,
-            ], ['connection']
+            ],
+            ['connection']
         );
     }
 }