Update to rubocop 1.59 [NTC-130]

[ric2b]

Problem

The current underlying version of rubocop doesn't support Ruby 3.3.

Solution

Bump the rubocop version to one that supports Ruby 3.3 (1.46+). Since we're upgrading we might as well upgrade to the latest version.

Blocking https://github.com/salsify/con-u/pull/5195

Prime: @erikkessler1 @jturkel
CC: @salsify/network-core

[erikkessler1]

We could drop Ruby 2.7 support while we're at it as 2.7 is EOL.

[ric2b]

The underlying rubocop version still supports it, so I think we might as well keep it as long as it doesn't hurt the maintenance of this gem.

Dropping support for ruby 2.7 might actually make it harder to move a project from 2.7 to 3+, since instead of bumping rubocop, fixing things and then bumping ruby, you are forced to either bump both of them together or go through 2 rubocop version upgrades.

[jturkel]

Are there any new cops in the updated version of Rubocop that we want to proactively enable or explicitly disable?

[ric2b]

Not sure, it's a very long list since 1.43: https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md

I guess I can try running this locally on con-u and give my opinion on any new complaints that I personally disagree with, but not sure how to arrive at a final list without reviewing all the new ones with some sort of committee.

[jturkel]

That is a long list. We can always defer this analysis after releasing/unblocking Ruby 3.3 support. The process for enabling/disabling cops is documented here. We're also very open to suggestions on how to evolve this process if you have ideas.

[ric2b]

@jturkel On con-u I didn't find any new complaints that I thought should be disabled. With the exception of Style/HashEachMethods, but actually it's already disabled by default but was enabled on con-u's configuration.

[ric2b]

Looks like I found one after all: #57