Skip to content

feat: allow users to pass more options to createFunction #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jaulz wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: allow users to pass more options to createFunction #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f4000d
feat: allow users to pass more options to `createFunction`
jaulz Dec 29, 2023
a58bc0b
fix: add missing type
jaulz Dec 29, 2023
1cdeaa0
style: fix lint issues
jaulz Dec 29, 2023
d8383f6
style: fix lint issues
jaulz Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/operations/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,16 @@ export function dropFunction(mOptions: MigrationOptions) {
export function createFunction(mOptions: MigrationOptions) {
// eslint-disable-next-line default-param-last
const _create: CreateFunction = (functionName, functionParams = [], functionOptions, definition) => {
const { replace, returns = 'void', language, window, behavior = 'VOLATILE', onNull, parallel } = functionOptions
const options = []
const {
replace,
returns = 'void',
language,
window,
behavior = 'VOLATILE',
onNull,
parallel,
options = [],
} = functionOptions
if (behavior) {
options.push(behavior)
}
Expand Down
1 change: 1 addition & 0 deletions src/operations/functionsTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export interface FunctionOptions {
behavior?: 'IMMUTABLE' | 'STABLE' | 'VOLATILE'
onNull?: boolean
parallel?: 'UNSAFE' | 'RESTRICTED' | 'SAFE'
options?: string[]
}

type CreateFunctionFn = (
Expand Down