Skip to content

formula-fetch: Allow MCP Gerrit, local fs git URI#38

Open
alexandruavadanii wants to merge 1 commit into
salt-formulas:masterfrom
alexandruavadanii:local-fs-git-formulas
Open

formula-fetch: Allow MCP Gerrit, local fs git URI#38
alexandruavadanii wants to merge 1 commit into
salt-formulas:masterfrom
alexandruavadanii:local-fs-git-formulas

Conversation

@alexandruavadanii

Copy link
Copy Markdown

Also fetch formulas from locations like:
FORMULA_SOURCES='file:///home/salt/formulas http://github.com/...'

To keep this change light, piggy-back on the fact that hosting is
empty for 'file://'.

Also fetch formulas from Gerrit / local filesystem locations like:

1. FORMULA_SOURCES='https://gerrit.mcp.mirantis.com/salt-formulas ...'
   The Gerrit URI is constructed like:
   https://<gerrit host>/<gerrit project prefix for filtering>

2. FORMULA_SOURCES='file:///home/salt/formulas ...'
   To keep this change light, piggy-back on the fact that `hosting`
   is empty for 'file://<absolute path to formulas dir>'.

To prevent fetching formula dependencies from github when fetching
all formulas from MCP Gerrit, add basic support for dependency skip.

Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
@alexandruavadanii alexandruavadanii changed the title formula-fetch: Allow local fs git URI formula-fetch: Allow MCP Gerrit, local fs git URI Nov 13, 2018
@alexandruavadanii

alexandruavadanii commented Nov 13, 2018

Copy link
Copy Markdown
Author

Hi,
I updated this PR with support for fetching all formulas from Gerrit (the usual use-case would be the gerrit.mcp.mirantis.com one).
A PoC leveraging both (Gerrit MCP + local filesystem) formula sources can be found in OPNFV at [1].
cc @mpolenchuk
[1] https://gerrit.opnfv.org/gerrit/#/c/62077/

@mpolenchuk

Copy link
Copy Markdown

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants