fix(minion): correct master_failback config option name#590
Merged
dafyddj merged 1 commit intoJun 27, 2026
Merged
Conversation
Contributor
Author
|
Heads up on the failing checks here — they're not from this change. The kitchen suites fail on a pre-existing breakage: salt installs "latest" over the image's pinned salt, and the in-place onedir swap crashes the post-install module refresh. After PR #591 is merged, rebasing this PR should make the checks pass. |
`salt/files/minion.d/f_defaults.conf` renders `master_fallback` /
`master_fallback_interval`, but Salt's options are `master_failback` /
`master_failback_interval`. Easy typo to miss — the embedded word should be
`fail`, not `fall`:
master_fallback <- template renders this (not a Salt option)
master_failback <- Salt's actual option
^
With no generic passthrough (only keys with an explicit `get_config` call are
rendered), setting `master_failback` in pillar is silently dropped today; the
correct spelling already appears in this file's comments.
Verify against Salt's source (VALID_OPTS / DEFAULT_MINION_OPTS):
https://github.com/saltstack/salt/blob/v3008.1/salt/config/__init__.py#L151-L154
https://github.com/saltstack/salt/blob/v3008.1/salt/config/__init__.py#L1132-L1133
Typo present since 2017 (edce95f).
Co-authored-by: Claude <noreply@anthropic.com>
pault-pg
force-pushed
the
fix-master-failback-typo
branch
from
31c149c to
231aa55
Compare
|
🎉 This PR is included in version 1.13.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
salt/files/minion.d/f_defaults.confrendersmaster_fallback/master_fallback_interval, but Salt's options aremaster_failback/master_failback_interval. Easy typo to miss — the embedded word should befail, notfall:With no generic passthrough (only keys with an explicit
get_configcall arerendered), setting
master_failbackin pillar is silently dropped today; thecorrect spelling already appears in this file's comments.
Verify against Salt's source (VALID_OPTS / DEFAULT_MINION_OPTS):
https://github.com/saltstack/salt/blob/v3008.1/salt/config/__init__.py#L151-L154
https://github.com/saltstack/salt/blob/v3008.1/salt/config/__init__.py#L1132-L1133
Typo present since 2017 (edce95f).
Co-authored-by: Claude noreply@anthropic.com