Skip to content

Format the shasum files correctly#39

Merged
twangboy merged 3 commits into
saltstack:mainfrom
twangboy:fix_shasum_format
Dec 9, 2025
Merged

Format the shasum files correctly#39
twangboy merged 3 commits into
saltstack:mainfrom
twangboy:fix_shasum_format

Conversation

@twangboy
Copy link
Copy Markdown
Contributor

@twangboy twangboy commented Dec 8, 2025

What does this PR do?

Fixes issues with the content of the shasum files. They need to work as expected. This means it needs to include the file name. I'm not sure why they weren't created that way to begin with.

Also fixes a few typos and an unneeded if statement.

Comment thread .github/workflows/release.yml Outdated
Comment on lines +151 to +152
sha256sum linux/svtminion.sh > svtminion.sh.sha256
sha256sum windows/svtminion.ps1 > svtminion.ps1.sha256
Copy link
Copy Markdown

@PaTHml PaTHml Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relative filepath will be included in the output.
Example: (2 spaces between checksum and file)
<some-checksum> linux/svtminion.sh

It's not wrong, but it is something to be aware of as the 'sha256sum --check ' command handling of the filepath will expect it to be present and relative to the working directory.

If there are sample validation commands, it should be clear the folder hierarchy be recreated on download.
If not, the filepath (if present) can be removed to flatten the downloads and validation to the working directory.

Generating:
<some-checksum> svtminion.sh
vs.
<some-checksum> linux/svtminion.sh

If the generated sha256 files are used in automation to validate the release data, then this might be adding inconveniences to that process instead of to the download validation.

Either way is good, just something to keep in mind.

Line comments with '#' can be manually added to the sha256 files if needed.
Example: (excuse the markup escapes)
# My comments
<some-checksum> linux/svtminion.sh

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is assuming the script and the shasum are downloaded and in the same directory. We're gonna keep it like this. We do the same thing with our bootstrap script.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you're saying... we need to remove the full path. You're right. I misunderstood your comments.

Copy link
Copy Markdown

@PaTHml PaTHml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the release.yml.
The rest LGTM but I'd need to see a sample output to be sure.

@twangboy twangboy merged commit ebdc398 into saltstack:main Dec 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants