fix(logging): tolerate unset options dict in worker bootstrap

CLI parsers seed salt._logging's global options dict at startup via
LogLevelMixIn.__setup_logging_config(). Non-CLI consumers
(RunnerClient.asynchronous, SSHClient, salt.utils.process.Process
subclasses, parallel states) have no parser, so the dict stays None.

Process.__new__ snapshots that None into instance.__logging_config__;
wrapped_run_func then calls set_logging_options_dict(None) defensively,
which forwards to set_lowest_log_level_by_opts(None).get(...) and
AttributeErrors on the worker. The parent exits 0 with a misleading
"Target did not return any data" / dead jid / 'result': None.

Make set_logging_options_dict(None) and setup_logging() (when nothing
has been seeded) no-op gracefully. Workers fall back to whatever logger
configuration they inherited from the parent. CLI tools always seed
before calling and are unaffected.

Fixes #68332

Signed-off-by: Teddy Andrieux <teddy.andrieux@scality.com>

Author: TeddyAndrieux

changelog/68332.fixed.md

@@ -0,0 +1 @@
+Fixed worker process crash when salt is used outside CLI tools.

salt/_logging/impl.py

@@ -449,6 +449,8 @@ def set_logging_options_dict(opts):
     """
     Create a logging related options dictionary based off of the loaded salt config
     """
+    if opts is None:
+        return
     try:
         if isinstance(set_logging_options_dict.__options_dict__, ImmutableDict):
             raise RuntimeError(
@@ -999,7 +1001,7 @@ def setup_log_granular_levels(log_granular_levels):
 def setup_logging():
     opts = get_logging_options_dict()
     if not opts:
-        raise RuntimeError("The logging options have not been set yet.")
+        return
     if (
         opts.get("configure_console_logger", True)
         and not is_console_handler_configured()

tests/pytests/functional/utils/test_process.py

@@ -203,3 +203,18 @@ def run_sync():
         assert ran == [True]
     finally:
         process_manager.terminate()
+
+
+def test_process_unseeded_logging_options():
+    """
+    Regression test for issue #68332.
+    """
+
+    def target():
+        pass
+
+    salt._logging.set_logging_options_dict.__options_dict__ = None
+    proc = salt.utils.process.Process(target=target)
+    proc.start()
+    proc.join()
+    assert proc.exitcode == 0

tests/pytests/unit/_logging/test_impl.py

@@ -0,0 +1,23 @@
+"""
+tests.pytests.unit._logging.test_impl
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Test salt's logging implementation
+"""
+
+import salt._logging.impl
+
+
+def test_set_logging_options_dict_with_none():
+    """
+    Regression test for issue #68332.
+    """
+    salt._logging.impl.set_logging_options_dict(None)
+
+
+def test_setup_logging_with_unseeded_options():
+    """
+    Regression test for issue #68332.
+    """
+    salt._logging.impl.set_logging_options_dict.__options_dict__ = None
+    salt._logging.impl.setup_logging()