Async batch#60269
Open
vzhestkov wants to merge 11 commits into
Open
Conversation
vzhestkov
force-pushed
the
batch-async-impl
branch
from
136bf98 to
7b44013
Compare
Contributor
|
@vzhestkov Just a heads up, there are quite a few merge conflicts here. |
Contributor
Author
|
@garethgreenaway thanks for pinging, I'll resolve them once I get some time for it, will try to do it as soon as possible |
twangboy
requested changes
May 2, 2022
vzhestkov
force-pushed
the
batch-async-impl
branch
from
7b44013 to
3cb0d22
Compare
Contributor
|
There are test failures |
Contributor
|
@vzhestkov A few test failures here and some requested changes. |
Contributor
|
We are close to tagging for the RC release for phosphorus. I would like to get this one in if the tests get fixed up |
Contributor
Author
|
Thanks for pinging. I'll try to fix all the suggestions today or tomorrow morning |
vzhestkov
force-pushed
the
batch-async-impl
branch
9 times, most recently
from
70c4853 to
e1e4b03
Compare
twangboy
requested changes
Jun 10, 2022
vzhestkov
force-pushed
the
batch-async-impl
branch
from
e1e4b03 to
a37729a
Compare
Contributor
Author
|
@twangboy thanks for pointing again, accidentally missed it. Fixed |
vzhestkov
force-pushed
the
batch-async-impl
branch
from
a37729a to
2def713
Compare
twangboy
previously approved these changes
Jun 14, 2022
Contributor
|
Theres a few tests failing on multiple platforms that seem to be related. |
vzhestkov
force-pushed
the
batch-async-impl
branch
from
b34e6fe to
a9884d8
Compare
vzhestkov
force-pushed
the
batch-async-impl
branch
2 times, most recently
from
40b7e09 to
6869add
Compare
3 tasks
twangboy
previously approved these changes
Feb 26, 2024
whytewolf
approved these changes
Feb 26, 2024
twangboy
previously approved these changes
Jan 29, 2025
3 tasks
Contributor
|
Looks like there are some test failures here |
Contributor
|
Please fix the conflicts |
Contributor
|
@vzhestkov Can you please rebase this 🙏 . We'll try to get it into 3008.0 |
Collaborator
|
looks like the current errors are related to the changes. |
Contributor
Author
|
@whytewolf sure, I will check. |
Co-authored-by: Mihai Dinca <dincamihai@gmail.com>
batch async: enhance trace logging batch async: do not block event handler additionally, only try to execute next batch once all previous minions has been processed somehow batch async: do not block current find_job execution batch async: just start batch if all minions returns the ping batch_async: ensure the start/done events are fired batch async: do not wait to finalize batch execution batch async: only trigger find job for current batch active minions Prevent traceback due missing 'send' method when socket was closed Modify some batch_async trace logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implementation of RFC#0002
#50546 port to
masterAll related tests migrated to
pytest