Fix 9 flaky tests identified in master nightly runs by Copilot · Pull Request #68893 · saltstack/salt

Copilot · 2026-04-04T05:28:02Z

Add pytest.mark.timeout(300) to test_state_running
Fix test_reauth: reduce default master-down wait from 150s to 60s (saves ~90s); add fast recon settings (recon_default=100ms, recon_max=1000ms) to minion so reconnect cycles are faster
Fix queue conftest: reduce parameterization from 4 to 2 sets (remove unlimited variants that don't reliably trigger queueing and were causing assertion failures); cuts queue test runtime by ~50%

Agent-Logs-Url: https://github.com/saltstack/salt/sessions/deaabf52-76a8-4db1-b762-2e0fad65099b Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Agent-Logs-Url: https://github.com/saltstack/salt/sessions/fbe1a82d-9244-49f2-87db-2260141d16b5 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

…ener cleanup, orchestrate race, queue timeout Agent-Logs-Url: https://github.com/saltstack/salt/sessions/655b4e54-fa1b-4a03-88fd-542afc927254 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Agent-Logs-Url: https://github.com/saltstack/salt/sessions/77d38b62-c3ff-4477-8f93-64f619a1469c Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

…moved imp module Agent-Logs-Url: https://github.com/saltstack/salt/sessions/0c65fdcf-5e00-4e84-ac8e-0d897b5fe7f9 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

…tify script Agent-Logs-Url: https://github.com/saltstack/salt/sessions/c099edf4-39cc-432a-a67b-e7d7f9330b03 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

… race The compound match policy G@testgrain:foo uses match.compound_matches with greedy=False (no uncached minions). When the x509 minion just started, its grains may not yet be in the master's cache, causing "minion not permitted to use specified signing policy". Retry up to 5 times with a 3s sleep to allow the grain cache to populate. Agent-Logs-Url: https://github.com/saltstack/salt/sessions/ff893826-902c-49d0-a5db-adf1de40e546 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

…ow ARM64 CI Agent-Logs-Url: https://github.com/saltstack/salt/sessions/821ecc21-bf86-4667-80c8-a3ceaeed77a1 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

… timeout kill Agent-Logs-Url: https://github.com/saltstack/salt/sessions/3cccd3f9-1bc6-4623-8910-4921c1a0cc58 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

…params 4->2 Agent-Logs-Url: https://github.com/saltstack/salt/sessions/13ec41f3-7ce6-478c-a6e4-03ff15214c38 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Copilot AI assigned Copilot and dwoz Apr 4, 2026

Copilot created this pull request from a session on behalf of dwoz April 4, 2026 05:28 View session

dwoz added the test:full Run the full test suite label Apr 4, 2026

dwoz had a problem deploying to ci April 4, 2026 05:28 — with GitHub Actions Error

Copilot AI temporarily deployed to ci April 4, 2026 05:28 Inactive

Copilot started work on behalf of dwoz April 4, 2026 05:29 View session

Copilot AI requested a review from dwoz April 4, 2026 05:31

Copilot finished work on behalf of dwoz April 4, 2026 05:31

dwoz removed the test:full Run the full test suite label Apr 4, 2026

dwoz had a problem deploying to ci April 4, 2026 05:43 — with GitHub Actions Error

dwoz added the test:full Run the full test suite label Apr 4, 2026

dwoz temporarily deployed to ci April 4, 2026 05:44 — with GitHub Actions Inactive

dwoz temporarily deployed to ci April 4, 2026 05:53 — with GitHub Actions Inactive

dwoz temporarily deployed to ci April 4, 2026 06:13 — with GitHub Actions Inactive

Copilot started work on behalf of dwoz April 4, 2026 06:45 View session

Copilot finished work on behalf of dwoz April 4, 2026 06:47

Copilot AI temporarily deployed to ci April 4, 2026 07:20 Inactive

Copilot AI temporarily deployed to ci April 4, 2026 07:30 Inactive

Copilot AI temporarily deployed to ci April 4, 2026 10:15 Inactive

Copilot started work on behalf of dwoz April 4, 2026 10:24 View session

Copilot finished work on behalf of dwoz April 4, 2026 10:27

Copilot started work on behalf of dwoz April 4, 2026 11:19 View session

Copilot finished work on behalf of dwoz April 4, 2026 11:27

Copilot AI temporarily deployed to ci April 4, 2026 11:57 Inactive

Copilot AI temporarily deployed to ci April 4, 2026 12:40 Inactive

Copilot AI temporarily deployed to ci April 4, 2026 13:58 Inactive

Copilot AI and others added 7 commits April 4, 2026 21:24

Fix 9 flaky tests in salt master nightly runs

da706c1

Agent-Logs-Url: https://github.com/saltstack/salt/sessions/deaabf52-76a8-4db1-b762-2e0fad65099b Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Fix black formatting in test_state.py

a4d1663

Agent-Logs-Url: https://github.com/saltstack/salt/sessions/fbe1a82d-9244-49f2-87db-2260141d16b5 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Fix 5 failing CI tests: mine allow_tgt, cache pillar race, event list…

e750d3e

…ener cleanup, orchestrate race, queue timeout Agent-Logs-Url: https://github.com/saltstack/salt/sessions/655b4e54-fa1b-4a03-88fd-542afc927254 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Apply black 24.2.0 formatting to test_orchestrate.py and test_cache.py

1dcfafd

Agent-Logs-Url: https://github.com/saltstack/salt/sessions/77d38b62-c3ff-4477-8f93-64f619a1469c Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Fix Python 3.12 incompatibilities: replace deprecated utcnow() and re…

12401d5

…moved imp module Agent-Logs-Url: https://github.com/saltstack/salt/sessions/0c65fdcf-5e00-4e84-ac8e-0d897b5fe7f9 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Fix test_zypp_plugins: use SourceFileLoader for extension-less zyppno…

d367de2

…tify script Agent-Logs-Url: https://github.com/saltstack/salt/sessions/c099edf4-39cc-432a-a67b-e7d7f9330b03 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

dwoz approved these changes Apr 5, 2026

View reviewed changes

Copilot AI and others added 3 commits April 5, 2026 10:03

Fix test_state_running timing: increase sleep and poll timeout for sl…

f982f16

…ow ARM64 CI Agent-Logs-Url: https://github.com/saltstack/salt/sessions/821ecc21-bf86-4667-80c8-a3ceaeed77a1 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Add pytest.mark.timeout(300) to test_state_running to fix 90s default…

b151238

… timeout kill Agent-Logs-Url: https://github.com/saltstack/salt/sessions/3cccd3f9-1bc6-4623-8910-4921c1a0cc58 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Fix scenarios test flakiness: reduce reauth sleep 150->60s and queue …

57fa272

…params 4->2 Agent-Logs-Url: https://github.com/saltstack/salt/sessions/13ec41f3-7ce6-478c-a6e4-03ff15214c38 Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 9 flaky tests identified in master nightly runs#68893

Fix 9 flaky tests identified in master nightly runs#68893
Copilot wants to merge 10 commits intomasterfrom
copilot/identify-flaky-tests

Copilot AI commented Apr 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 4, 2026 •

edited

Loading