Calculate UUID grain for Xen PV guests#69036
Open
ycedres wants to merge 4 commits into
Open
Conversation
ycedres
force-pushed
the
calculate-uuid-grain-xen-pv-guest
branch
from
d552f44 to
07bbaae
Compare
3 tasks
but /sys/class/dmi/id is missing
The unit test `test__hw_data_linux_empty` was failing because of existing mocks for fopen in rb mode. Switching to rb does no harm because of the use of `to_unicode` of the `/sys/hypervisor/uuid` file contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On Linux systems running as Xen paravirtualized (PV) guests, standard DMI/SMBIOS tools (like dmidecode) may not be available or may not provide the correct hardware UUID. Instead, Xen provides this information via /sys/hypervisor/uuid.
This PR updates the core grains to prioritize reading the UUID from the Xen hypervisor path when it exists.
What issues does this PR fix or reference?
Tracks https://github.com/SUSE/spacewalk/issues/29298
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes