Change zypperpkg to only parse stdout from rpm#69503
Open
tacerus wants to merge 1 commit into
Open
Conversation
If `rpm` on a system returns warnings on stderr, parsing would fail
```
...
provide, realname = line.split("_|-")
ValueError: not enough values to unpack (expected 2, got 1)
```
and render related functions unusable.
Generally, query output to process should only be expected on stdout.
Hence, solve the issue and ensure functionality regardless of warnings
by discarding stderr.
Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Contributor
Author
|
Any help what's wrong with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If
rpmon a system returns warnings on stderr, parsing would failand render related functions unusable.
Generally, query output to process should only be expected on stdout. Hence, solve the issue and ensure functionality regardless of warnings by discarding stderr.
What issues does this PR fix or reference?
Fixes #69502.
Previous Behavior
pkg states fail if rpm returns warnings.
New Behavior
pkg states work regardless of rpm returning warnings, matching native zypper behavior.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes