ci: register the nightly stress workflow on master#69577
Merged
Conversation
The Nightly Stress Test workflow was added to 3006.x in saltstack#69227 but the scheduled ``cron`` only fires for workflows that live on the repository's default branch -- so the nightly run never triggers until the file lands on master. This change copies just the workflow file across so the schedule registers and ``workflow_dispatch`` works against master too. The supporting ``tests/monitoring/`` scaffolding is intentionally left to arrive via the natural 3006.x -> 3007.x -> 3008.x -> master forward merges; runs invoked before that landing will fail in the "Build and Start Environment" step with a clear missing-directory error, which is acceptable for the short gap. Also fixes a stale path in the "Collect Logs on Failure" step -- ``monitoring/event_log.txt`` -> ``tests/monitoring/event_log.txt``.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nightly Stress Test workflow was added to 3006.x in #69227 but the scheduled
crononly fires for workflows that live on the repository's default branch -- so the nightly run never triggers until the file lands on master.This change copies just the workflow file across so the schedule registers and
workflow_dispatchworks against master too. The supportingtests/monitoring/scaffolding is intentionally left to arrive via the natural 3006.x -> 3007.x -> 3008.x -> master forward merges; runs invoked before that landing will fail in the "Build and Start Environment" step with a clear missing-directory error, which is acceptable for the short gap.Also fixes a stale path in the "Collect Logs on Failure" step --
monitoring/event_log.txt->tests/monitoring/event_log.txt.What does this PR do?
What issues does this PR fix or reference?
Fixes
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No