test: improve coverage for service/routes/auth and fix bug

Author: jescalada

src/service/routes/auth.js

@@ -109,24 +109,28 @@ router.get('/profile', async (req, res) => {
 router.post('/gitAccount', async (req, res) => {
   if (req.user) {
     try {
-      let login =
+      let username =
         req.body.username == null || req.body.username == 'undefined'
           ? req.body.id
           : req.body.username;
+      username = username?.split('@')[0];
 
-      login = login.split('@')[0];
+      if (!username) {
+        res.status(400).send('Error: Missing username. Git account not updated').end();
+        return;
+      }
 
-      const user = await db.findUser(login);
+      const user = await db.findUser(username);
 
       console.log('Adding gitAccount' + req.body.gitAccount);
       user.gitAccount = req.body.gitAccount;
       db.updateUser(user);
       res.status(200).end();
-    } catch {
+    } catch (e) {
       res
         .status(500)
         .send({
-          message: 'An error occurred',
+          message: `Error updating git account: ${e.message}`,
         })
         .end();
     }

test/testLogin.test.js

@@ -52,6 +52,27 @@ describe('auth', async () => {
       res.should.have.status(200);
     });
 
+    it('should be able to set the git account', async function () {
+      console.log(`cookie: ${cookie}`);
+      const res = await chai.request(app).post('/api/auth/gitAccount')
+        .set('Cookie', `${cookie}`)
+        .send({
+          username: 'admin',
+          gitAccount: 'new-account',
+        });
+      res.should.have.status(200);
+    });
+
+    it('should throw an error if the username is not provided when setting the git account', async function () {
+      const res = await chai.request(app).post('/api/auth/gitAccount')
+        .set('Cookie', `${cookie}`)
+        .send({
+          gitAccount: 'new-account',
+        });
+      console.log(`res: ${JSON.stringify(res)}`);
+      res.should.have.status(400);
+    });
+
     it('should now be able to logout', async function () {
       const res = await chai.request(app).post('/api/auth/logout').set('Cookie', `${cookie}`);
       res.should.have.status(200);
@@ -78,6 +99,19 @@ describe('auth', async () => {
       });
       res.should.have.status(401);
     });
+
+    it('should fail to set the git account if the user is not logged in', async function () {
+      const res = await chai.request(app).post('/api/auth/gitAccount').send({
+        username: 'admin',
+        gitAccount: 'new-account',
+      });
+      res.should.have.status(401);
+    });
+
+    it('should fail to get the current user metadata if not logged in', async function () {
+      const res = await chai.request(app).get('/api/auth/me');
+      res.should.have.status(401);
+    });
   });
 
   after(async function () {