chore: remove unused auth endpoints and function

The getUser function on git-push.js (which used the api/auth/success endpoint) was exported but not used anywhere else

Author: jescalada

src/service/routes/auth.js

@@ -65,29 +65,6 @@ router.get('/oidc/callback', (req, res, next) => {
   })(req, res, next);
 });
 
-// when login is successful, retrieve user info
-router.get('/success', (req, res) => {
-  console.log('authenticated' + JSON.stringify(req.user));
-  if (req.user) {
-    res.json({
-      success: true,
-      message: 'user has successfully authenticated',
-      user: req.user,
-      cookies: req.cookies,
-    });
-  } else {
-    res.status(401).end();
-  }
-});
-
-// when login failed, send failed msg
-router.get('failed', (req, res) => {
-  res.status(401).json({
-    success: false,
-    message: 'user failed to authenticate.',
-  });
-});
-
 router.post('/logout', (req, res, next) => {
   req.logout(req.user, (err) => {
     if (err) return next(err);

src/ui/services/git-push.js

@@ -9,21 +9,6 @@ const config = {
   withCredentials: true,
 };
 
-const getUser = async (setIsLoading, setData, setAuth, setIsError) => {
-  const url = new URL(`${location.origin}/api/auth/success`);
-  await axios(url.toString(), config)
-    .then((response) => {
-      const data = response.data;
-      setData(data);
-      setIsLoading(false);
-    })
-    .catch((error) => {
-      if (error.response && error.response.status === 401) setAuth(false);
-      else setIsError(true);
-      setIsLoading(false);
-    });
-};
-
 const getPush = async (id, setIsLoading, setData, setAuth, setIsError) => {
   const url = `${baseUrl}/push/${id}`;
   await axios(url, config)

test/testLogin.test.js

@@ -112,6 +112,14 @@ describe('auth', async () => {
       const res = await chai.request(app).get('/api/auth/me');
       res.should.have.status(401);
     });
+
+    it('should fail to login with invalid credentials', async function () {
+      const res = await chai.request(app).post('/api/auth/login').send({
+        username: 'admin',
+        password: 'invalid',
+      });
+      res.should.have.status(401);
+    });
   });
 
   after(async function () {