docs(concat): example uses lo.Concat, not lo.Flatten#889
Merged
samber merged 1 commit intoMay 23, 2026
Conversation
The Concat doc page on lo.samber.dev currently shows a lo.Flatten call under the Concat heading, which is what the reporter screenshot in samber#859 caught. Fix the snippet to actually call lo.Concat. Closes samber#859 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
==========================================
- Coverage 92.57% 92.55% -0.02%
==========================================
Files 32 32
Lines 5067 5067
==========================================
- Hits 4691 4690 -1
- Misses 273 274 +1
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #859.
The Concat doc page on lo.samber.dev was showing a
lo.Flatten(list1, list2)call under the Concat heading, which is what the screenshot in the issue caught. Fix the example to actually uselo.Concat.No source change, both helpers already exist.