feat: add toggle checks for discovery BLE authentication requirements

Author: sameerasw

app/src/main/java/com/sameerasw/airsync/data/ble/BleGattServer.kt

@@ -74,6 +74,16 @@ class BleGattServer(private val context: Context) {
             return
         }
 
+        val isEnabled = try {
+            runBlocking { dataStoreManager.getBleSyncEnabled().first() }
+        } catch (e: Exception) {
+            false
+        }
+        if (!isEnabled) {
+            Log.d(TAG, "BLE Sync is disabled in settings, skipping start")
+            return
+        }
+
         // Set Bluetooth adapter name dynamically based on configured device name to keep BLE matching precise
         val customName = try {
             runBlocking { dataStoreManager.getDeviceName().first() }
@@ -244,7 +254,17 @@ class BleGattServer(private val context: Context) {
                     _connectionState.value = if (gattServer != null) BleConnectionState.ADVERTISING else BleConnectionState.DISCONNECTED
                     isAuthenticated = false
                     if (gattServer != null) {
-                        startAdvertising()
+                        val isEnabled = try {
+                            runBlocking { dataStoreManager.getBleSyncEnabled().first() }
+                        } catch (e: Exception) {
+                            false
+                        }
+                        if (isEnabled) {
+                            startAdvertising()
+                        } else {
+                            Log.d(TAG, "BLE Sync is disabled, stopping server")
+                            stop()
+                        }
                     }
                 }
             }
@@ -268,6 +288,14 @@ class BleGattServer(private val context: Context) {
         override fun onCharacteristicWriteRequest(device: BluetoothDevice, requestId: Int, characteristic: BluetoothGattCharacteristic, preparedWrite: Boolean, responseNeeded: Boolean, offset: Int, value: ByteArray) {
             Log.d(TAG, "Write request for ${characteristic.uuid}, length: ${value.size}")
 
+            if (characteristic.uuid != BleConstants.CHAR_AUTH_TOKEN && !isAuthenticated) {
+                Log.w(TAG, "Blocked unauthorized write request to ${characteristic.uuid} from ${device.address}")
+                if (responseNeeded) {
+                    gattServer?.sendResponse(device, requestId, BluetoothGatt.GATT_WRITE_NOT_PERMITTED, offset, null)
+                }
+                return
+            }
+            
             when (characteristic.uuid) {
                 BleConstants.CHAR_AUTH_TOKEN -> handleAuthRequest(device, value)
                 BleConstants.CHAR_MAC_BATTERY -> handleMacBattery(value)

app/src/main/java/com/sameerasw/airsync/utils/UDPDiscoveryManager.kt

@@ -119,6 +119,11 @@ object UDPDiscoveryManager {
     }
 
     fun burstBroadcast(context: Context, durationMs: Long = 30000) {
+        if (!isDiscoveryEnabled) {
+            Log.d(TAG, "Discovery disabled, skipping burst broadcast")
+            return
+        }
+        
         Log.d(TAG, "Starting burst broadcast for ${durationMs}ms")
         burstJob?.cancel()
         burstJob = CoroutineScope(Dispatchers.IO).launch {
@@ -346,6 +351,8 @@ object UDPDiscoveryManager {
     }
 
     private fun broadcastPresence(context: Context) {
+        if (!isDiscoveryEnabled) return
+        
         val allIps = getAllIpAddresses()
         if (allIps.isEmpty()) {
             return
@@ -427,6 +434,8 @@ object UDPDiscoveryManager {
     }
 
     private fun broadcastGoodbye(context: Context) {
+        if (!isDiscoveryEnabled) return
+        
         val allIps = getAllIpAddresses()
         if (allIps.isEmpty()) return
 
@@ -447,7 +456,7 @@ object UDPDiscoveryManager {
                         val packet = DatagramPacket(
                             data,
                             data.size,
-                            InetAddress.getByName("255.55.255.255"),
+                            InetAddress.getByName("255.255.255.255"),
                             BROADCAST_PORT
                         )
                         DatagramSocket(0, InetAddress.getByName(bindIp)).use { sender ->