Skip to content

Commit 228a7be

Browse files
authored
Merge pull request #1 from sameersayani/master
corrected version
2 parents ce368dc + 958dced commit 228a7be

File tree

1 file changed

+11
-23
lines changed

1 file changed

+11
-23
lines changed

demo.js

Lines changed: 11 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -23,29 +23,17 @@ async function fetchData(url) {
2323
}
2424
}
2525

26-
//function to convert any currency to INR using a fixed exchange ratefunction, intentioanally add cognitive complexity by using multiple if-else statements
26+
//function to convert any currency to INR using a fixed exchange rate function
2727
function convertToINR(amount, currency) {
28-
let exchangeRate;
29-
if (currency === 'USD') {
30-
exchangeRate = 74.85;
31-
} else if (currency === 'EUR') {
32-
exchangeRate = 88.50;
33-
} else if (currency === 'GBP') {
34-
exchangeRate = 103.25;
35-
} else if (currency === 'JPY') {
36-
exchangeRate = 0.68;
37-
} else if (currency === 'AUD') {
38-
exchangeRate = 55.30;
39-
} else if (currency === 'CAD') {
40-
exchangeRate = 59.20;
41-
} else if (currency === 'CHF') {
42-
exchangeRate = 82.10;
43-
} else if (currency === 'CNY') {
44-
exchangeRate = 11.50;
45-
} else if (currency === 'HKD') {
46-
exchangeRate = 9.60;
47-
} else {
28+
const exchangeRates = {
29+
USD: 74.85,
30+
EUR: 88.50,
31+
GBP: 103.20,
32+
JPY: 0.68
33+
};
34+
if (Object.hasOwn(exchangeRates, currency)) {
35+
return amount * exchangeRates[currency];
36+
} else {
4837
throw new Error('Unsupported currency');
49-
}
50-
return amount * exchangeRate;
38+
}
5139
}

0 commit comments

Comments
 (0)