Skip to content

Commit 671768e

Browse files
th-2021kkimurak
authored andcommitted
fix GITLAB_AGENT_BUILTIN_KAS_ENABLED == false
1 parent 772be4c commit 671768e

2 files changed

Lines changed: 13 additions & 10 deletions

File tree

assets/runtime/env-defaults

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -708,3 +708,4 @@ GITLAB_AGENT_KAS_PRIVATE_API_LISTEN_AUTHENTICATION_SECRET_FILE=${GITLAB_AGENT_KA
708708
GITLAB_AGENT_KAS_WEBSOCKET_TOKEN_SECRET_FILE=${GITLAB_AGENT_KAS_WEBSOCKET_TOKEN_SECRET_FILE:-${GITLAB_INSTALL_DIR}/.gitlab_kas_websocket_token_secret}
709709
GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE=${GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE:-}
710710
GITLAB_AGENT_KAS_GITLAB_AUTHENTICATION_SECRET_FILE=${GITLAB_AGENT_KAS_GITLAB_AUTHENTICATION_SECRET_FILE:-${GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE}}
711+
GITLAB_AGENT_BUILTIN_KAS_ENABLED=${GITLAB_AGENT_BUILTIN_KAS_ENABLED:-false}

assets/runtime/functions

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -400,15 +400,17 @@ gitlab_configure_gitlab_kas() {
400400
GITLAB_KAS_PROXY
401401

402402
printf "Configuring gitlab-agent::KAS (enabled: %s)\n" "${GITLAB_AGENT_BUILTIN_KAS_ENABLED}"
403-
update_template ${GITLAB_KAS_CONFIG} \
404-
GITLAB_RELATIVE_URL_ROOT \
405-
GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE \
406-
GITLAB_AGENT_KAS_PRIVATE_API_LISTEN_AUTHENTICATION_SECRET_FILE \
407-
GITLAB_AGENT_KAS_WEBSOCKET_TOKEN_SECRET_FILE \
408-
REDIS_HOST \
409-
REDIS_PORT \
410-
GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE
411-
403+
if [[ ${GITLAB_AGENT_BUILTIN_KAS_ENABLED} == true ]]; then
404+
update_template ${GITLAB_KAS_CONFIG} \
405+
GITLAB_RELATIVE_URL_ROOT \
406+
GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE \
407+
GITLAB_AGENT_KAS_PRIVATE_API_LISTEN_AUTHENTICATION_SECRET_FILE \
408+
GITLAB_AGENT_KAS_WEBSOCKET_TOKEN_SECRET_FILE \
409+
REDIS_HOST \
410+
REDIS_PORT \
411+
GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE
412+
fi
413+
412414
if [[ -n ${GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE} ]]; then
413415
exec_as_git touch "${GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE}"
414416
exec_as_git chmod 600 "${GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE}"
@@ -1006,7 +1008,7 @@ gitlab_configure_secrets() {
10061008
chmod 600 "${pages_secret}"
10071009
fi
10081010

1009-
if [[ ! -f "${GITLAB_AGENT_kas_aPI_LISTEN_AUTHENTICATION_SECRET_FILE}" ]]; then
1011+
if [[ ! -f "${GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE}" ]]; then
10101012
exec_as_git openssl rand -base64 -out "${GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE}" 32
10111013
chmod 600 ${GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE}
10121014
fi

0 commit comments

Comments
 (0)