Skip to content

Commit d01a4b7

Browse files
th-2021kkimurak
authored andcommitted
fix GITLAB_AGENT_BUILTIN_KAS_ENABLED == false
1 parent 8373a7c commit d01a4b7

2 files changed

Lines changed: 13 additions & 10 deletions

File tree

assets/runtime/env-defaults

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -693,3 +693,4 @@ GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE=${GITLAB_AGENT_KAS_API_LI
693693
GITLAB_AGENT_KAS_PRIVATE_API_LISTEN_AUTHENTICATION_SECRET_FILE=${GITLAB_AGENT_KAS_PRIVATE_API_LISTEN_AUTHENTICATION_SECRET_FILE:-${GITLAB_INSTALL_DIR}/.gitlab_kas_private_api_secret}
694694
GITLAB_AGENT_KAS_WEBSOCKET_TOKEN_SECRET_FILE=${GITLAB_AGENT_KAS_WEBSOCKET_TOKEN_SECRET_FILE:-${GITLAB_INSTALL_DIR}/.gitlab_kas_websocket_token_secret}
695695
GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE=${GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE:-}
696+
GITLAB_AGENT_BUILTIN_KAS_ENABLED=${GITLAB_AGENT_BUILTIN_KAS_ENABLED:-false}

assets/runtime/functions

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -375,15 +375,17 @@ gitlab_configure_gitlab_kas() {
375375
GITLAB_KAS_PROXY
376376

377377
printf "Configuring gitlab-agent::KAS (enabled: %s)\n" "${GITLAB_AGENT_BUILTIN_KAS_ENABLED}"
378-
update_template ${GITLAB_KAS_CONFIG} \
379-
GITLAB_RELATIVE_URL_ROOT \
380-
GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE \
381-
GITLAB_AGENT_KAS_PRIVATE_API_LISTEN_AUTHENTICATION_SECRET_FILE \
382-
GITLAB_AGENT_KAS_WEBSOCKET_TOKEN_SECRET_FILE \
383-
REDIS_HOST \
384-
REDIS_PORT \
385-
GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE
386-
378+
if [[ ${GITLAB_AGENT_BUILTIN_KAS_ENABLED} == true ]]; then
379+
update_template ${GITLAB_KAS_CONFIG} \
380+
GITLAB_RELATIVE_URL_ROOT \
381+
GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE \
382+
GITLAB_AGENT_KAS_PRIVATE_API_LISTEN_AUTHENTICATION_SECRET_FILE \
383+
GITLAB_AGENT_KAS_WEBSOCKET_TOKEN_SECRET_FILE \
384+
REDIS_HOST \
385+
REDIS_PORT \
386+
GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE
387+
fi
388+
387389
if [[ -n ${GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE} ]]; then
388390
exec_as_git touch "${GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE}"
389391
exec_as_git chmod 600 "${GITLAB_AGENT_KAS_REDIS_PASSWORD_FILE}"
@@ -963,7 +965,7 @@ gitlab_configure_secrets() {
963965
chmod 600 "${pages_secret}"
964966
fi
965967

966-
if [[ ! -f "${GITLAB_AGENT_kas_aPI_LISTEN_AUTHENTICATION_SECRET_FILE}" ]]; then
968+
if [[ ! -f "${GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE}" ]]; then
967969
exec_as_git openssl rand -base64 -out "${GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE}" 32
968970
chmod 600 ${GITLAB_AGENT_KAS_API_LISTEN_AUTHENTICATION_SECRET_FILE}
969971
fi

0 commit comments

Comments
 (0)